Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filelist overlap with header ref #16076 #16366

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Fix filelist overlap with header ref #16076 #16366

merged 1 commit into from
Jul 18, 2019

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jul 11, 2019 •
edited
Loading

ref #16076
Before
before1
After
after1

@GretaD GretaD requested a review from skjnldsv July 11, 2019 15:38
skjnldsv
skjnldsv requested changes Jul 12, 2019
View reviewed changes
core/css/styles.scss Outdated Show resolved Hide resolved
@skjnldsv skjnldsv added 2. developing Work in progress bug design Design, UI, UX, etc. feature: files labels Jul 12, 2019
@GretaD GretaD force-pushed the bugfix/noid/filelist-overlap branch from 1b515c8 to 73f7b70 Compare July 12, 2019 13:47
@GretaD GretaD requested a review from skjnldsv July 12, 2019 13:48
@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 17, 2019
@rullzer rullzer added this to the Nextcloud 17 milestone Jul 17, 2019
@MorrisJobke MorrisJobke mentioned this pull request Jul 17, 2019
Merged
28 tasks
@GretaD GretaD requested a review from georgehrke July 18, 2019 13:07
georgehrke
georgehrke approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@georgehrke georgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 18, 2019
@GretaD @rullzer
Fix filelist overlap with header ref #16076
e1da99a 
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@rullzer rullzer force-pushed the bugfix/noid/filelist-overlap branch from eb91040 to e1da99a Compare July 18, 2019 13:35
@MorrisJobke MorrisJobke merged commit 94d9ebd into master Jul 18, 2019
@MorrisJobke MorrisJobke deleted the bugfix/noid/filelist-overlap branch July 18, 2019 18:55
@jancborchardt jancborchardt mentioned this pull request Jul 18, 2019
Closed
77 tasks
@GretaD GretaD mentioned this pull request Aug 28, 2019
Closed
@Noodlesalat Noodlesalat mentioned this pull request Nov 18, 2019
Closed
Noodlesalat added a commit to Noodlesalat/server that referenced this pull request Nov 18, 2019
@Noodlesalat
Remove whitespace above file list
49f921f 
This reverts nextcloud#16366 and fixes nextcloud#17891

Signed-off-by: Fabian Dreßler <nudelsalat@clouz.de>
@Noodlesalat Noodlesalat mentioned this pull request Nov 18, 2019
Merged
Noodlesalat added a commit to Noodlesalat/server that referenced this pull request Nov 18, 2019
@Noodlesalat
Remove whitespace above file list
0b2e32f 
This reverts nextcloud#16366 and fixes nextcloud#17891

Signed-off-by: Fabian Dreßler <nudelsalat@clouz.de>
Noodlesalat added a commit to Noodlesalat/server that referenced this pull request Nov 18, 2019
@Noodlesalat
Remove whitespace above file list
8261e74 
This reverts nextcloud#16366 and fixes nextcloud#17891

Signed-off-by: Fabian Dreßler <nudelsalat@clouz.de>
@kesselb kesselb mentioned this pull request Dec 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@georgehrke georgehrke georgehrke approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: files
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.
6 participants
@GretaD @georgehrke @juliushaertl @skjnldsv @rullzer @MorrisJobke