Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable17] Fix fetching additional search results on scrolling down #17305

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 28, 2019

backport of #15557
cc @rbuehlma @noelmartinon

@skjnldsv
Copy link
Member

skjnldsv commented Sep 28, 2019

@rullzer Handlebar have issues because the script uses npm i handlebar -g which install the latest, but our package requires the same as what is in the node_modules I think.

We should put the script in the package.json so we can use the same installed version :)

"message": "Error: Template was precompiled with a newer version of Handlebars
than the current runtime. Please update your runtime to a newer version
(>= 4.3.0).\nat core/js/dist/main.js:299:0"

@juliushaertl
Copy link
Member

Rebased to include #17348

@rullzer
Copy link
Member

rullzer commented Oct 8, 2019

/compile amend /

@skjnldsv
Copy link
Member

skjnldsv commented Oct 8, 2019

One more issue with the infamouse npm i / npm ci :(

Signed-off-by: René Bühlmann <rene@buehlmann.net>
@rullzer
Copy link
Member

rullzer commented Oct 22, 2019

/compile amend /

@rullzer rullzer merged commit 6c64af1 into stable17 Oct 22, 2019
@rullzer rullzer deleted the backport/15557/stable17 branch October 22, 2019 20:30
@rullzer rullzer mentioned this pull request Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants