-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable28] Backport unified search improvments #42432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
approved these changes
Dec 21, 2023
sorbaugh
approved these changes
Dec 22, 2023
skjnldsv
approved these changes
Dec 22, 2023
emoral435
approved these changes
Dec 22, 2023
d99c860
to
8d3ad03
Compare
/compile |
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
On change/input from user which has the effect of filtering, we want to send the query to the API to obtained fresh results, based on the databased on not just preloaded contacts. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
As expected, a user does not see themselves in their contact list, however, when using the contact list for filtering search, a user, might want to limit the search to things that pertain to them. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
4055134
to
67a874a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport #42167 and #42205