Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IPv6 database hosts #9225

Merged
merged 4 commits into from
Apr 22, 2018
Merged

Allow IPv6 database hosts #9225

merged 4 commits into from
Apr 22, 2018

Conversation

nickvergessen
Copy link
Member

Replace #7621
Fix #9157

Signed-off-by: Joas Schilling <coding@schilljs.com>
@rullzer
Copy link
Member

rullzer commented Apr 18, 2018

Can we extract this to a fuction and add tests for it?
I don't trust my regex review skills :P

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Done

@codecov
Copy link

codecov bot commented Apr 19, 2018

Codecov Report

Merging #9225 into master will increase coverage by <.01%.
The diff coverage is 90%.

@@             Coverage Diff              @@
##             master    #9225      +/-   ##
============================================
+ Coverage     51.91%   51.91%   +<.01%     
- Complexity    25361    25366       +5     
============================================
  Files          1606     1607       +1     
  Lines         95311    95328      +17     
  Branches       1394     1394              
============================================
+ Hits          49478    49489      +11     
- Misses        45833    45839       +6
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/ConnectionFactory.php 67.07% <90%> (+8.09%) 24 <3> (+1) ⬆️
core/js/sharedialogshareelistview.js 48.42% <0%> (-0.36%) 0% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.46% <0%> (-0.25%) 136% <0%> (ø)
...iles_sharing/composer/composer/autoload_static.php 0% <0%> (ø) 1% <0%> (ø) ⬇️
...es_sharing/composer/composer/autoload_classmap.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
...g/lib/BackgroundJob/FederatedSharesDiscoverJob.php 30.76% <0%> (ø) 3% <0%> (?)
lib/private/OCS/DiscoveryService.php 86.2% <0%> (+0.49%) 13% <0%> (+1%) ⬆️

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member

I just added some more tests to cover also domain names 😉

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense and still works 👍

@rullzer rullzer merged commit 9f4e928 into master Apr 22, 2018
@rullzer rullzer deleted the bugfix/9157/ipv6-database-host branch April 22, 2018 18:43
@MorrisJobke
Copy link
Member

@nickvergessen Could you open the backport for stable13?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants