-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow IPv6 database hosts #9225
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Can we extract this to a fuction and add tests for it? |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Done |
Codecov Report
@@ Coverage Diff @@
## master #9225 +/- ##
============================================
+ Coverage 51.91% 51.91% +<.01%
- Complexity 25361 25366 +5
============================================
Files 1606 1607 +1
Lines 95311 95328 +17
Branches 1394 1394
============================================
+ Hits 49478 49489 +11
- Misses 45833 45839 +6
|
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
I just added some more tests to cover also domain names 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense and still works 👍
@nickvergessen Could you open the backport for stable13? |
Replace #7621
Fix #9157