Open conversations: Text not vertically aligned

[jancborchardt]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. Go to Talk
2. Open the 3-dot action menu
3. Pick "Join open conversations"

Expected behaviour

The list looks nice and consistent with the rest.

Actual behaviour

• The text is not vertically aligned with the avatar / image
• The images are not shown, but instead a "?" in place of all of them
  

Talk app

Talk app version: Current on cloud.nc and tech-preview as well.

[nickvergessen]

• Avatar thing is known: Conversations not joined yet show ? instead of conversation avatar in search results #9600 but hard to fix without reducing security quite a bit.

[SystemKeeper]

• Avatar thing is known: Conversations not joined yet show ? instead of conversation avatar in search results #9600 but hard to fix without reducing security quite a bit.

If we can't securely fix this (now), we could at least prevent the requests to the server and show a placeholder?!

[Antreesy]

• The text is not vertically aligned with the avatar / image

It should be aligned geometrically, but due to upstream component issue (see PR above), it has 0-height invisible element, which forces text to be slightly higher and jump on toggle

[jancborchardt]

If we can't securely fix this (now), we could at least prevent the requests to the server and show a placeholder?!

Yes definitely. We can use this "groups" icon: https://fonts.google.com/icons?selected=Material%20Icons%3Agroups%3A

It should be aligned geometrically, but due to upstream component issue (see PR above), it has 0-height invisible element, which forces text to be slightly higher and jump on toggle

@Antreesy is this being worked on?

[jancborchardt]

Ah the avatar was already fixed as per #10222, great stuff! :)

[Antreesy]

is this being worked on?

Please check tommorow at company instance, or locally. Should be aligned with vue-library bump

[nickvergessen]

This is from the package I just build, so I guess the alignment is not fully working (chrome)

[Antreesy]

I guess the alignment is not fully working (chrome)

Oh wow, I have thought about LeftSidebar, not the OpenConversations Modal 🙈

cc @DorraJaouad please check, if you have time