Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference_id check #12428

Closed
SystemKeeper opened this issue May 27, 2024 · 0 comments · Fixed by #12496
Closed

Remove reference_id check #12428

SystemKeeper opened this issue May 27, 2024 · 0 comments · Fixed by #12496
Assignees
Labels
1. to develop enhancement feature: api 🛠️ OCS API for conversations, chats and participants good first issue
Milestone

Comments

@SystemKeeper
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

We have checks in place to verify that the reference_id column on oc_comments exists, e.g.:

if ($schema->hasTable('comments')) {
$table = $schema->getTable('comments');
if ($table->hasColumn('reference_id')) {
$this->serverConfig->setAppValue('spreed', 'has_reference_id', 'yes');
$this->jobList->remove(self::class);
}
}

spreed/lib/Capabilities.php

Lines 250 to 252 in ada7048

if ($this->serverConfig->getAppValue('spreed', 'has_reference_id', 'no') === 'yes') {
$capabilities['features'][] = 'chat-reference-id';
}

Since Nextcloud 29 the reference_id column was added to a migration, making it mandatory for all installations:

https://github.com/nextcloud/server/blob/ae4a6e8d4454b7896d0e40f367096a26d999dbf0/core/Migrations/Version29000Date20231213104850.php#L49-L55

Therefore I suggest that we remove the BackgroundJob and the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement feature: api 🛠️ OCS API for conversations, chats and participants good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants