Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PublicShareAuthSidebar): fix and refactor styles for video verification sidebar #12853

Merged
merged 6 commits into from
Aug 1, 2024
Merged

fix(PublicShareAuthSidebar): fix and refactor styles for video verification sidebar #12853

merged 6 commits into from
Aug 1, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 30, 2024 •
edited
Loading

☑️ Resolves

  • Fix broken styles
  • apply box-sizing: border-box
  • adjust spacings
  • fix colors and text appearance

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image Screenshot from 2024-07-30 13-56-40
Auth --
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy
fix(PublicShareAuthSidebar): fix and refactor styles for video verifi…
212cdf0 
…cation sidebar

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(TopBar): remove reserved space for toggles
e03f9a7 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(TopBar): pass correct color to conversation type icon
fef0f97 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(CallButton): hide button text when in sidebar (as in mobile)
a970896 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 3. to review bug feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Jul 30, 2024
@Antreesy Antreesy added this to the 💙 Next Beta (30) milestone Jul 30, 2024
@Antreesy Antreesy requested a review from ShGKme July 30, 2024 12:09
@Antreesy Antreesy self-assigned this Jul 30, 2024
@Antreesy
fix(PublicShareSidebar): hide duplicated CallButton
af3cc0c 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy mentioned this pull request Jul 30, 2024
Merged
5 tasks
@Antreesy
style: adjust publicshareauth.css to stretch body component to the vi…
57ead93 
…ewport height

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
DorraJaouad
DorraJaouad approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🌟

src/components/TopBar/CallButton.vue Show resolved Hide resolved
@Antreesy Antreesy merged commit ef1465a into main Aug 1, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/video-verify-styles branch August 1, 2024 10:13
@Antreesy Antreesy mentioned this pull request Aug 1, 2024
Merged
5 tasks
@nickvergessen nickvergessen mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Milestone
v20.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad