Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate icon-url on call rich objects #9072

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Populate icon-url on call rich objects #9072

merged 7 commits into from
Apr 4, 2023

Commits on Apr 4, 2023

  1. Document icon-url on call rich objects 

    #8333 introduced an optional `icon-url`
for the call objects in rich messages.

#8389

Signed-off-by: Vitor Mattos <vitor@php.rio>
    @vitormattos @nickvergessen
    vitormattos authored and nickvergessen committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    557fab1 View commit details
    Browse the repository at this point in the history

  2. Fix method to get avatarURL and validate the URL 

    https://github.com/nextcloud/spreed/pull/9072/files#r1142350857

Signed-off-by: Vitor Mattos <vitor@php.rio>
    @vitormattos @nickvergessen
    vitormattos authored and nickvergessen committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    dfac403 View commit details
    Browse the repository at this point in the history

  3. Validate icon-url when test share of rich object 

    #9072 (comment)

Signed-off-by: Vitor Mattos <vitor@php.rio>
    @vitormattos @nickvergessen
    vitormattos authored and nickvergessen committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    567c7bb View commit details
    Browse the repository at this point in the history

  4. Make the version optional 

    We only have the query string "version" when send an avatar after the
first version of avatar

Signed-off-by: Vitor Mattos <vitor@php.rio>
    @vitormattos @nickvergessen
    vitormattos authored and nickvergessen committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    89f93d4 View commit details
    Browse the repository at this point in the history

  5. COnsider that the icon-url will come every time 

    Signed-off-by: Vitor Mattos <vitor@php.rio>
    @vitormattos @nickvergessen
    vitormattos authored and nickvergessen committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    de21738 View commit details
    Browse the repository at this point in the history

  6. Also default avatar works 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    a529fea View commit details
    Browse the repository at this point in the history

  7. fix(tests): Make sure avatar service is actually called 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    3c00ae5 View commit details
    Browse the repository at this point in the history