Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar delete wording #1290

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Fix calendar delete wording #1290

merged 2 commits into from
Oct 14, 2020

Conversation

raimund-schluessler
Copy link
Member

  • Don't show calendar delete option if the calendar is read-only (e.g. a list from Deck)
  • Call calendars that don't support tasks "lists" to prevent confusion

Closes #1279.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #1290 into master will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
- Coverage   27.67%   27.56%   -0.11%     
==========================================
  Files          47       47              
  Lines        2656     2666      +10     
  Branches      505      514       +9     
==========================================
  Hits          735      735              
- Misses       1779     1789      +10     
  Partials      142      142              

@raimund-schluessler raimund-schluessler merged commit 9f1f5dc into master Oct 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/1279/wording branch October 14, 2020 19:38
@raimund-schluessler
Copy link
Member Author

I will wait for a couple of days before releasing a new version to let the translations being updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Deleting the calendar in {countdown}"
1 participant