Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display tasks with future start date dimly #1998

Merged
merged 7 commits into from
May 16, 2022
Merged

Display tasks with future start date dimly #1998

merged 7 commits into from
May 16, 2022

Conversation

nico-nacq
Copy link
Contributor

@nico-nacq nico-nacq commented May 9, 2022

Render future tasks (tasks with a start date in the future) differently than other tasks : Lower opacity, little icon on the right. Italic text.

Before :
2022-05-09_23-04-05

After :
2022-05-10_10-49-08

2022-05-10_10-50-22

What changes :
2022-05-10_10-49-35

EDIT : After a few tweeks suggested by @raimund-schluessler, here's the result :
2022-05-12_14-12-25
(no italic, better icon and alt text)

(This is the first time I make a PR. Hope I'm doing it right 🤞)

Thank you 😊

@raimund-schluessler
Copy link
Member

@nico-nacq Thanks for your PR. I left a few comments. In principle I am fine with changing the appearance of future tasks, but I would like to hear @nextcloud/designers about this as well.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1998 (ebc8c0d) into master (00dc26d) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1998      +/-   ##
============================================
- Coverage     29.27%   29.17%   -0.10%     
  Complexity       41       41              
============================================
  Files            69       69              
  Lines          2982     2992      +10     
  Branches        663      667       +4     
============================================
  Hits            873      873              
- Misses         2109     2119      +10     

@nico-nacq
Copy link
Contributor Author

@nico-nacq Thanks for your PR. I left a few comments. In principle I am fine with changing the appearance of future tasks, but I would like to hear @nextcloud/designers about this as well.

Thank you so much for considering my PR and for your work !

@jancborchardt
Copy link
Member

Nice, good idea!

Just some concern regarding accessibility and readability: We do have the variable --color-text-maxcontrast which is subdued but ensures proper contrast, but it has to be on --color-main-background (not grey as well) to be readable. Would be better to use that, and the text + checkbox color adjustment is probably enough?

@raimund-schluessler
Copy link
Member

Nice, good idea!

Just some concern regarding accessibility and readability: We do have the variable --color-text-maxcontrast which is subdued but ensures proper contrast, but it has to be on --color-main-background (not grey as well) to be readable. Would be better to use that, and the text + checkbox color adjustment is probably enough?

Would look like this (second task starts in the future, icon omitted, since it's only done in devtools):
Screenshot 2022-05-16 at 14-49-35 Aufgaben - Nextcloud

@raimund-schluessler
Copy link
Member

I would prefer it without a background as well. If one wants a different background color, it will be very simple to change it with the custom CSS app, since we now set a CSS class for tasks starting in the future with this PR.

@nico-nacq
Copy link
Contributor Author

nico-nacq commented May 16, 2022

Just some concern regarding accessibility and readability: We do have the variable --color-text-maxcontrast which is subdued but ensures proper contrast, but it has to be on --color-main-background (not grey as well) to be readable. Would be better to use that, and the text + checkbox color adjustment is probably enough?

Ok done : a1abc27

  • The background stays unchanged.
  • The text goes to --color-text-maxcontrast.
  • The checkbox still fades to .2
  • The icon is still added on the right.

It looks like this :

2022-05-16_16-24-07

2022-05-16_16-24-27

Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me>

Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me>

Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me>

Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me>

Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me>
@raimund-schluessler raimund-schluessler merged commit 17e3f4e into nextcloud:master May 16, 2022
@nico-nacq
Copy link
Contributor Author

Thank you 🙏🥲

@jancborchardt
Copy link
Member

Looks great, nice work @nico-nacq! Looking forward to more design contributions from you if you like. :) Check https://nextcloud.com/design for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants