-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display tasks with future start date dimly #1998
Display tasks with future start date dimly #1998
Conversation
@nico-nacq Thanks for your PR. I left a few comments. In principle I am fine with changing the appearance of future tasks, but I would like to hear @nextcloud/designers about this as well. |
Codecov Report
@@ Coverage Diff @@
## master #1998 +/- ##
============================================
- Coverage 29.27% 29.17% -0.10%
Complexity 41 41
============================================
Files 69 69
Lines 2982 2992 +10
Branches 663 667 +4
============================================
Hits 873 873
- Misses 2109 2119 +10 |
Thank you so much for considering my PR and for your work ! |
Nice, good idea! Just some concern regarding accessibility and readability: We do have the variable |
I would prefer it without a background as well. If one wants a different background color, it will be very simple to change it with the custom CSS app, since we now set a CSS class for tasks starting in the future with this PR. |
Ok done : a1abc27
It looks like this : |
Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me> Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me> Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me> Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me> Signed-off-by: nico-nacq <nico@nacq.me>
Signed-off-by: nico-nacq <nico@nacq.me>
Thank you 🙏🥲 |
Looks great, nice work @nico-nacq! Looking forward to more design contributions from you if you like. :) Check https://nextcloud.com/design for more info |
Render future tasks (tasks with a start date in the future) differently than other tasks : Lower opacity, little icon on the right. Italic text.
Before :
![2022-05-09_23-04-05](https://user-images.githubusercontent.com/93337483/167498303-29325957-23cd-47c3-9e6f-9f02d09cfdd2.png)
After :
![2022-05-10_10-49-08](https://user-images.githubusercontent.com/93337483/167589088-73d162e5-920e-4f5f-9af0-ce48269ed020.png)
What changes :
![2022-05-10_10-49-35](https://user-images.githubusercontent.com/93337483/167589165-e887a61d-a863-48cc-a2fd-d4e3e8036b2d.png)
EDIT : After a few tweeks suggested by @raimund-schluessler, here's the result :
![2022-05-12_14-12-25](https://user-images.githubusercontent.com/93337483/168106772-77f8ccb4-ee59-482d-9399-0b6bc04e7e52.png)
(no italic, better icon and alt text)
(This is the first time I make a PR. Hope I'm doing it right 🤞)
Thank you 😊