-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SCSS into components #2016
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2016 +/- ##
=========================================
Coverage 29.17% 29.17%
Complexity 41 41
=========================================
Files 69 69
Lines 2992 2992
Branches 667 667
=========================================
Hits 873 873
Misses 2119 2119 |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
f347e9a
to
e99dd8d
Compare
Merging, since otherwise Tasks is not usable with NC25. More fixes/adjustments in a follow-up, if necessary. |
In the Talk integration menu. But I guess that anyway needs adjustments for md icons. |
Yes, or a wider discussion about how we do icons in APIs :) |
Since Nextcloud server 25 will stop compiling SCSS files, we have to compile it ourself. Hence, we move the SCSS code into the vue components.
@skjnldsv What is left is including icons for circles in
tasks/css/tasks.scss
Line 1 in f4738a1
Any recommendation how to do this for Nextcloud 25?