Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SCSS into components #2016

Merged
merged 2 commits into from May 30, 2022
Merged

Move SCSS into components #2016

merged 2 commits into from May 30, 2022

Conversation

raimund-schluessler
Copy link
Member

Since Nextcloud server 25 will stop compiling SCSS files, we have to compile it ourself. Hence, we move the SCSS code into the vue components.

@skjnldsv What is left is including icons for circles in

@include icon-black-white('circle', 'tasks', 1);

Any recommendation how to do this for Nextcloud 25?

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #2016 (e99dd8d) into master (778a4f0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2016   +/-   ##
=========================================
  Coverage     29.17%   29.17%           
  Complexity       41       41           
=========================================
  Files            69       69           
  Lines          2992     2992           
  Branches        667      667           
=========================================
  Hits            873      873           
  Misses         2119     2119           

@raimund-schluessler
Copy link
Member Author

@skjnldsv I just saw, server provides an icon-circles class with the correct icon. So I can use this.
But for

@include icon-black-white('tasks', 'tasks', 1);

the question remains, I guess.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler
Copy link
Member Author

Merging, since otherwise Tasks is not usable with NC25. More fixes/adjustments in a follow-up, if necessary.

@raimund-schluessler raimund-schluessler merged commit a36ce1e into master May 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/compile-scss branch May 30, 2022 20:22
@skjnldsv
Copy link
Member

@skjnldsv I just saw, server provides an icon-circles class with the correct icon. So I can use this. But for

@include icon-black-white('tasks', 'tasks', 1);

the question remains, I guess.

I'd say move it to server.
Where is this being used?

@raimund-schluessler
Copy link
Member Author

@skjnldsv I just saw, server provides an icon-circles class with the correct icon. So I can use this. But for

@include icon-black-white('tasks', 'tasks', 1);

the question remains, I guess.

I'd say move it to server.

Where is this being used?

In the Talk integration menu. But I guess that anyway needs adjustments for md icons.

@skjnldsv
Copy link
Member

In the Talk integration menu. But I guess that anyway needs adjustments for md icons.

Yes, or a wider discussion about how we do icons in APIs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants