Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use circular progress bar instead of linear bar #2464

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

raimund-schluessler
Copy link
Member

@raimund-schluessler raimund-schluessler commented Jan 20, 2024

This PR changes the progress / completion bar from linear to circular. It uses less space and the length and position is always the same. Requires nextcloud-libraries/nextcloud-vue#5100.

Before:
grafik

After:
grafik

Closes #1439.

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from design perspective. Thanks for implementing this! :)

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler
Copy link
Member Author

Merging now. Once there is a new nc/vue release, we will have to adjust the import accordingly. Tracked in #2453.

@raimund-schluessler raimund-schluessler merged commit 987f8b8 into master Jan 22, 2024
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/1439/circular-progress branch January 22, 2024 10:06
@jancborchardt
Copy link
Member

I find the linear one a more obvious for comparisons. :) Generally the rule of thumb is:

  • Linear for longer loading and if space is available (which is both the case here)
  • Circular for shorter and where space is small (e.g. spinners, or mobile app installation with indicator on icon)

But your call of course. :) As an enhancement, it would be nice if the indicator circles all line up, so if they are always the element left next of the action menu.

@raimund-schluessler
Copy link
Member Author

I find the linear one a more obvious for comparisons. :)

I understand your point, and I also think that linear bars can have advantages here. But the problem was that the bars don't always have the same total length. And there isn't really a fix for this, since subtasks are indented and shorter. So comparing different bars could be a bit misleading, see the originial issue #1439.

So, I think cirular is a bit better suited here, although it's probably a gray area 🙈

As an enhancement, it would be nice if the indicator circles all line up, so if they are always the element left next of the action menu.

That's a good idea, I will do this. see #2466.

@jancborchardt
Copy link
Member

@raimund-schluessler ah, missed the link to the original issue, sorry. :) Right, the issue of variable widths (or rather start and end points) is indeed an issue. Then let's see how this fares. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Length of completion bar is wrong
3 participants