New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the vue-components for app-navigation and app-content #818
Conversation
9ef4567
to
ea33698
Compare
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
==========================================
+ Coverage 27.84% 31.92% +4.07%
==========================================
Files 15 23 +8
Lines 1142 1253 +111
Branches 223 223
==========================================
+ Hits 318 400 +82
- Misses 700 729 +29
Partials 124 124 |
This should be good now. Drag and drop also works and even sets the background color on hover (which it didn't before). There might be a problem with dropping a task on the app-navigation on touch devices, but I cannot check that since I don't own a touch device large enough for showing the app-navigation and the task list. However, if it really doesn't work there is an alternative way to dropping tasks on the sidebar. |
3e377bc
to
e1961de
Compare
e1961de
to
1bb7b37
Compare
eb65ffe
to
a47f1c1
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
a47f1c1
to
d4fe678
Compare
This should fix #804 and lead to a more uniform look of the Tasks app.
Left to do for this PR:
While working on this, I noticed a few other things that should be improved in follow-up PRs:
Another thing that should be fixed in the vue-components is the opacity of inactive navigation items and their hover state: nextcloud-libraries/nextcloud-vue#425. Although the proposal nextcloud-libraries/nextcloud-vue#425 (comment) looks very good, there wasn't much progress on implementing it lately. @skjnldsv Should we work-around it here or wait for the issue to be resolved?