Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the vue-components for app-navigation and app-content #818

Merged
merged 9 commits into from Feb 9, 2020

Conversation

raimund-schluessler
Copy link
Member

@raimund-schluessler raimund-schluessler commented Jan 22, 2020

This should fix #804 and lead to a more uniform look of the Tasks app.

Left to do for this PR:

  • Find a way to have drag and drop on collections and lists/calendars
  • Implement adding a task list
  • Properly style the list editing GUI
  • Implement the timeout GUI for deleting a calendar

While working on this, I noticed a few other things that should be improved in follow-up PRs:

Another thing that should be fixed in the vue-components is the opacity of inactive navigation items and their hover state: nextcloud-libraries/nextcloud-vue#425. Although the proposal nextcloud-libraries/nextcloud-vue#425 (comment) looks very good, there wasn't much progress on implementing it lately. @skjnldsv Should we work-around it here or wait for the issue to be resolved?

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #818 into master will increase coverage by 4.07%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
+ Coverage   27.84%   31.92%   +4.07%     
==========================================
  Files          15       23       +8     
  Lines        1142     1253     +111     
  Branches      223      223              
==========================================
+ Hits          318      400      +82     
- Misses        700      729      +29     
  Partials      124      124

@raimund-schluessler
Copy link
Member Author

This should be good now. Drag and drop also works and even sets the background color on hover (which it didn't before). There might be a problem with dropping a task on the app-navigation on touch devices, but I cannot check that since I don't own a touch device large enough for showing the app-navigation and the task list. However, if it really doesn't work there is an alternative way to dropping tasks on the sidebar.

@raimund-schluessler
Copy link
Member Author

Ping @skjnldsv, after #837 it's time to review this PR 😉

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler merged commit 44c1c0d into master Feb 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the more-vue-components branch February 9, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and Drop on iOS 13.3 only selects text
2 participants