Fix header popover in file browser #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
added a commit
to nextcloud/server
that referenced
this pull request
Aug 12, 2021
Otherwise this will creates a minor visual glitch when nextcloud/text#1821 will get merged. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
|
/compile amend |
src/views/RichWorkspace.vue
Outdated
| overflow: scroll !important; | ||
| max-height: 50vh; | ||
| max-height: 40vh; |
There was a problem hiding this comment.
Reducing the rich workspace height more would box it in a bit much, no? Otherwise the change seems good.
There was a problem hiding this comment.
I probably should use calc(50vh - 50px) so that it use a similar size has before
There was a problem hiding this comment.
Is that needed for the fix?
There was a problem hiding this comment.
The new code doesn't apply the max-height on the editor but on the content instead so using calc(50vh - 50px) make it so that the height of the editor is the same as before
CarlSchwan
force-pushed
the
work/popover
branch
from
d5d46f8
to
18cee24
Compare
|
/compile amend |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
work/popover
branch
from
18cee24
to
0b361a2
Compare
juliushaertl
approved these changes
Aug 17, 2021
|
/backport to stable22 |
|
The backport to stable22 failed. Please do this backport manually. |
max-nextcloud
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously the popover for the header in the file browser was cut off. Now instead of making the whole text editor scrollable, only the content is.
Missing to make this patch perfect is changing the z-index from 61 to 62 in the server repo, which I will do shortly