Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @nextcloud/vue to ^8.0.0-beta.5 (main) #4700

Merged
merged 3 commits into from Aug 29, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 18, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@nextcloud/vue ^8.0.0-beta.2 -> ^8.0.0-beta.5 age adoption passing confidence

Release Notes

nextcloud-libraries/nextcloud-vue (@​nextcloud/vue)

v8.0.0-beta.5

Compare Source

What's Changed

🐛 Fixed bugs
Other Changes

Full Changelog: nextcloud-libraries/nextcloud-vue@v8.0.0-beta.4...v8.0.0-beta.5

v8.0.0-beta.4

Compare Source

What's Changed

🚀 Enhancements
🐛 Fixed bugs
Other Changes

Full Changelog: nextcloud-libraries/nextcloud-vue@v8.0.0-beta.3...v8.0.0-beta.4

v8.0.0-beta.3

Compare Source

Full Changelog

💥 Breaking changes
  • Update node engines to next LTS (node 20 / npm 9)
  • The deprecated NcMultiselect and NcMultiselectTags components were removed #​4281 (susnux)
    • Migration: Use the NcSelect and NcSelectTags components instead
  • The deprecated NcPopoverMenu component was removed #​4081 (raimund-schluessler)
    • Migration: Use the NcActions component instead
  • The deprecated NcAppNavigationCounter component was removed #​4096 (raimund-schluessler)
    • Migration: Use the NcCounterBubble component instead
  • The deprecated excludeClickOutsideClasses property was removed from clickOutsideOptions #​4088 (raimund-schluessler)
    • Migration: Use the excludeClickOutsideSelectors property, which takes an array of css selectors, instead
  • The label property of NcAutoCompleteResult was renamed to title #​4222 (susnux)
  • The deprecated title property was removed, every occurrence of title was renamed to name #​4106 (raimund-schluessler), #​4052 (raimund-schluessler)
    • label property was renamed to name for NcMentionBubble
    • name propery is now required for NcActions*, NcAppNavigationItem and NcBreadcrumb*
    • See linked pull request for full migration guide
  • chore: Drop install entry point and replace it with an Vue Plugin #​4349 (susnux)
🚀 Enhancements
  • enh(NcDatetime): New component for displaying timestamps as time relative from now #​4219 (susnux)
  • feat(NcInputField): Append custom aria-describedby to input field #​4225 (Pytal)
  • feat(NcNoteCard): Add new 'info' version to display informational messaged #​4063 (moan0s)
  • feat(NcEmptyContent): Add slot for description #​3895 (susnux)
  • feat(NcActions): Improve readability of action menu entries #​4049 (Pytal)
  • feat(NcReferencePickerModal): Allow setting modal size when registering a custom picker component #​3866 (julien-nc)
  • feat: Migrate NcAvatar to use NcActions #​4017 (raimund-schluessler)
  • feat(a11y): Export a11y activation util #​4166 (Pytal)
  • NcButton: Add alignment property to change icon and text ordering #​4366 (susnux)
🐛 Fixed bugs
  • fix(NcSettingsSelectGroup): Migrate from deprecated NcMultiselect to NcSelect #​4120 (susnux)
  • fix(NcRichtext): Migrate from deprecated NcMultiselect to NcSelect #​4247 (julien-nc)
  • fix(NcAppNavigation): Prevent tabbing into closed navigation #​3114 (PVince81)
  • fix(NcDatetimePicker): Make sure all l10n strings are extracted #​4272 (susnux)
  • fix(NcAppNavigationCaption): Align actions with other navigation action #​4220 (susnux)
  • fix(NcInputField): Increase input field helper text contrast #​4188 (Pytal)
  • fix(NcSelect): Hide clear and deselect button when disabled #​4212 (Pytal)
  • fix(NcSelect): Fix disabled colors to distinguish the disabled state from the regular state #​4217 (Pytal)
  • fix(NcProviderList): Add padding around provider list #​4175 (juliushaertl)
  • fix(NcModal): Fix focus-trap fallback if content is empty #​4266 (skjnldsv)
  • fix(NcActionInput): Show trailing button even for empty input #​4251 (susnux)
  • fix(NcRichContenteditable): Fix mentioning users with @ in username #​4222 (susnux)
  • fix(NcProgressBar): Fix design on chromium browsers #​4238 (szaimon)
  • fix(NcReferencePicker): Fix padding in the any link preview component #​4248 (julien-nc)
  • fix(NcModal): Set background and text color #​4221 (susnux)
  • fix(NcSelect): Keep dropdown open while loading #​4209 (Pytal)
  • fix(NcCheckboxRadioSwitch): Add focus-visible style #​4176 (Fenn-CS)
  • fix(NcAppNavigationSettings): Add aria-expanded attribute to settings accordion button #​4109 (Fenn-CS)
  • fix(clickOutsideOptions): Fix handling of ignored css selectors #​4046 (susnux)
  • fix(NcResource): Fix item alignment in the right sidebar #​4121 (Pytal)
  • fix(NcAppSidebarTabs): Fix rendering tabs with CSS icon #​4111 (ShGKme)
  • fix(NcAppNavigationItem): Left panel dropdown improvement #​4103 (Jerome-Herbinet)
  • fix(NcSettingsSection): Add target blank and no ref info #​4099 (Rello)
  • fix: Use the color-primary-element* variables in components #​4067 (szaimon)
  • fix(NcListItem): Fix wrong bold class #​4083 (julien-nc)
  • fix(NcSelect): Fix disabled state of NcSelect with dark mode #​4079 (nickvergessen)
  • fix(NcSelect): Action input usage #​4066 (Pytal)
  • fix(NcRichContenteditable): Fix avatar overlayed with empty space when offline #​4043 (nickvergessen)
  • fix(l10n): Add language mappings like server does so gettext uses the same locale #​4412 (susnux)
  • fix(l10n): Remove quoting character #​4396 (rakekniven)
  • fix(NcModal): prev/next color and sizing fix #​4368 (skjnldsv)
  • fix(NcListItem) - define a single place for NcActions to render #​4356 (Antreesy)
  • fix(NcModal): Close button should be visible even if modal content is scrolled #​4350 (susnux)
  • fix(NcButton): Improve alignment documentation to show all variants. #​4392 (susnux)
  • try to fix header size on mobile #​4420 (szaimen)
  • fix(NcButton): correctly emit click event #​4398 (raimund-schluessler)
  • feat(NcButton): Add pressed state for stateful buttons #​4344 (susnux)
  • NcCheckboxRadioSwitch - adjust border color #​4427 (szaimen)
  • fix(NcRichContenteditable): Add aria-placeholder #​4407 (ShGKme)
  • fix(NcModal): Fix modal focus trap with additional elements and arrow navigation #​4406 (ShGKme)

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 18, 2023
@renovate renovate bot requested review from a team, juliushaertl and luka-nextcloud and removed request for a team August 18, 2023 22:39
@renovate renovate bot force-pushed the renovate/main-nextcloud-vue-8.x branch from 8b3cbe5 to 52a74a2 Compare August 25, 2023 19:40
@renovate renovate bot changed the title fix(deps): update dependency @nextcloud/vue to ^8.0.0-beta.3 (main) fix(deps): update dependency @nextcloud/vue to ^8.0.0-beta.4 (main) Aug 25, 2023
@renovate renovate bot force-pushed the renovate/main-nextcloud-vue-8.x branch from 52a74a2 to 4ccbcde Compare August 28, 2023 19:47
@renovate renovate bot changed the title fix(deps): update dependency @nextcloud/vue to ^8.0.0-beta.4 (main) fix(deps): update dependency @nextcloud/vue to ^8.0.0-beta.5 (main) Aug 28, 2023
@max-nextcloud
Copy link
Collaborator

/compile

@max-nextcloud
Copy link
Collaborator

builds are failing since beta.3

autoUpdate is clearly exported in @floating-ui/dom.

I wonder what text is messing with there.

Might be related to floating-ui/floating-ui#2449

@juliushaertl
Copy link
Member

I'm wondering if the lock file is somewhat stuck with an old peer dependency. Maybe running npm install --save @nextcloud/vue@^8.0.0-beta.5 locally and committing the lock file change does any help. I had this at some point before as well.

Maybe also check npm ls @floating-ui/dom on this branch to see which versions get pulled in

@juliushaertl
Copy link
Member

@nextcloud/text@28.0.0-dev.1 /Users/julius/repos/nextcloud/server/apps/text
└─┬ @nextcloud/vue@8.0.0-beta.2 invalid: "^8.0.0-beta.5" from the root project
├── @floating-ui/dom@1.4.2
└─┬ floating-vue@1.0.0-beta.19
└── @floating-ui/dom@0.1.10

@juliushaertl
Copy link
Member

Didn't work but i pushed a fix to avoid our manual change of the webpack module loading order as introduced in #345 which i think should no longer be necessary now that tiptap has its own bundled prosemirror packages

@renovate
Copy link
Contributor Author

renovate bot commented Aug 29, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@cypress
Copy link

cypress bot commented Aug 29, 2023

Passing run #11919 ↗︎

0 133 18 0 Flakiness 0

Details:

fix(deps): update dependency @nextcloud/vue to ^8.0.0-beta.5 (main)
Project: Text Commit: d8f2598c4d
Status: Passed Duration: 04:05 💡
Started: Aug 29, 2023 7:46 PM Ended: Aug 29, 2023 7:50 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@max-nextcloud
Copy link
Collaborator

oh... nice - looks like all that is missing now is a rebase and a compile.
🎉 Thanks a lot for looking into this Julius!

@juliushaertl juliushaertl force-pushed the renovate/main-nextcloud-vue-8.x branch from 309ecfb to 92d33a7 Compare August 29, 2023 19:37
@juliushaertl
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliushaertl juliushaertl merged commit e6a69be into main Aug 29, 2023
31 checks passed
@juliushaertl juliushaertl deleted the renovate/main-nextcloud-vue-8.x branch August 29, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants