fix: select all in code block #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed and 2 flaky tests on run #11912 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Text PROPFIND extension > with workspaces enabled > adds rich workspace property to nested folders |
Output
Screenshots
|
|
attachments.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Test all attachment insertion methods > See test files in the list and display hidden files |
Output
Screenshots
|
|
MenuBar.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Test the rich text editor menu bar > word count > multiple words |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
juliushaertl
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Works. We can extend the test cases for this after #4663 is in
Signed-off-by: Luka Trovic <luka@nextcloud.com>
juliushaertl
force-pushed
the
bugfix/select-all-in-codeblock
branch
from
5bbff5d
to
63ac0d3
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
/backport to stable27 |
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
@luka-nextcloud Can you take care of the backport? |
|
/backport 63ac0d3 to stable27 |
|
This already got backported to stable27 with #4748. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)