Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use proper value for checking if editable #4721

Merged
merged 2 commits into from Sep 6, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 24, 2023

Use the right property for checking if the editor is read only

@cypress
Copy link

cypress bot commented Aug 24, 2023

3 failed tests on run #12039 ↗︎

3 137 18 0 Flakiness 0

Details:

fix: Use proper value for checking if editable
Project: Text Commit: ff3ea0000a
Status: Failed Duration: 05:18 💡
Started: Sep 6, 2023 6:46 AM Ended: Sep 6, 2023 6:51 AM
Failed  cypress/e2e/attachments.spec.js • 3 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > test if attachment folder is moved with the markdown file Output Screenshots
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Aug 28, 2023
@juliushaertl
Copy link
Member Author

/backport to stable27

@juliushaertl
Copy link
Member Author

Let's wait for #4663 so I can extend with a test for this one

@juliushaertl juliushaertl force-pushed the bugfix/noid/code-block-editable branch 3 times, most recently from 49aec00 to 00ba58a Compare August 30, 2023 12:08
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 162af60 into main Sep 6, 2023
28 of 32 checks passed
@juliushaertl juliushaertl deleted the bugfix/noid/code-block-editable branch September 6, 2023 07:12
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-
Copy link
Member

mejo- commented Dec 5, 2023

/backport 468edd4 to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants