[stable28] feat: add labels to textarea elements in translate modal #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
Signed-off-by: Luka Trovic <luka@nextcloud.com>
backportbot
bot
requested review from
juliushaertl,
ShGKme and
luka-nextcloud
|
/compile amend/ |
emoral435
approved these changes
Jan 29, 2024
luka-nextcloud
approved these changes
Jan 29, 2024
|
Not to familiar with the text app, so if everything looks good after compiling, and after the freezes, this is perfect! Thank you @luka-nextcloud for the support for accessibility on the website 😊 |
|
We can drop the compile commit here before merging as we have automated that part (for the stable28 branch and up) in text as a proof of concept. It will happen after the merge. |
emoral435
force-pushed
the
backport/5234/stable28
branch
from
f1da10a
to
1c47c4d
Compare
|
That's actually so cool! Is that a process that we would be able to move to the main sever repo as well 👀 haha |
juliushaertl
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #5234