Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App not wotking after upgrade from v23 to v24 #113

Closed
3 tasks
adripo opened this issue Dec 5, 2022 · 5 comments
Closed
3 tasks

App not wotking after upgrade from v23 to v24 #113

adripo opened this issue Dec 5, 2022 · 5 comments
Labels
to be closed This indicates an older issue that may not be valid anymore

Comments

@adripo
Copy link

adripo commented Dec 5, 2022

use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

  • This is not a feature request
  • This is not an image-provider request
  • I have searched the issuetracker if the issue is not already reported.

Describe the bug:

After upgrading from v23 to v24 this app stopped wotking. In the user settings the only visible part is this one

image

without any possible choice for the images.

In the system settings this is selected. Even if I enable by default no image is shown anyway.

image

To Reproduce:
Steps to reproduce the behavior:

  1. Go to Settings
  2. Click on Splash
  3. See error

Expected behavior:

Be able to select where to apply background user-per-user

Server:

  • Nextcloud version: v24.0.7
  • Splash-App version: 2.0.1

Additional Information:
No info on system log.
Is it possilbe to remove some broken settings on the db to fix the issue?

@adripo adripo added the bug label Dec 5, 2022
@adripo
Copy link
Author

adripo commented Dec 5, 2022

Additional logs:
image

@newhinton
Copy link
Contributor

(Nearly) All the user settings have been removed for 2.0.0.

The dashboard can be selected by the user anyway on the dashbard itself, we autodetect the default image there and replace it with the unsplash one.

The login can't be changed by the user anyway, and the header-settings are only visible to the user if they are enabled by the admin in the theming settings. (And in 25 even this is gone because there is no "header" anymore, the background is implicitly set by the user's background.)

@tonytonyistony
Copy link

tonytonyistony commented Jan 5, 2023

Additional logs: image
I am also getting these errors in my logs. When I check the folder path specified I get the following files.

-rw-r--r-- 1 www-data www-data  451 Dec 21 06:46 licenseUnsplash.php
-rw-r--r-- 1 www-data www-data  450 Dec 21 06:46 licenseWallhavenCC.php
-rw-r--r-- 1 www-data www-data  341 Dec 21 06:46 licenseWikimediaCommons.php

Thinking about renaming one of the to license and see what happens.

Also my splash screens are working as they should. Just getting the error logs.

EDIT:
Confirmed that Im using the WallhavenCC splash screens. I made a copy of the licenseWallhavenCC.php and named it license.php. Now the errors do not exist.

@newhinton
Copy link
Contributor

@tonytonyistony I think this is not related to this issue. i have referenced this in #114.

@adripo I assume that all questions have been cleared up, and with no further interaction i will close this ticket soon. If you have additional questions please ask!

@newhinton newhinton added to be closed This indicates an older issue that may not be valid anymore and removed bug labels Jan 8, 2023
@adripo
Copy link
Author

adripo commented Jan 11, 2023

@newhinton Thank you for the clarification. I will close the issue.

@adripo adripo closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be closed This indicates an older issue that may not be valid anymore
Projects
None yet
Development

No branches or pull requests

3 participants