Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"We couldn't find this image" - background image is replaced by 404 image #134

Closed
3 tasks done
qudiqudi opened this issue Mar 7, 2024 · 8 comments
Closed
3 tasks done
Labels
Needs more Info This ticket requires more information to be worked on to be closed This indicates an older issue that may not be valid anymore wontfix

Comments

@qudiqudi
Copy link

qudiqudi commented Mar 7, 2024

use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

  • This is not a feature request
  • This is not an image-provider request
  • I have searched the issuetracker if the issue is not already reported.

Describe the bug:
Images are not loaded, a 404 error page is shown instead in the background.
background image get's replaced by this 404 error page:

https://images.unsplash.com/source-404?fit=crop&fm=jpg&h=800&q=60&w=1200

Screenshots:
grafik

Server:

  • Nextcloud version: Nextcloud Hub 6 (27.1.5)
  • Splash-App version: latest available via app-store 2.2.1

Additional Information:
I can reach unsplash.com just fine from my network, so I doubt it is a dns or geo-block issue (location: Germany)

@qudiqudi qudiqudi added the bug label Mar 7, 2024
@qudiqudi qudiqudi changed the title "We cannot show this image" - background image is replaced by 404 image "We couldn't find this image" - background image is replaced by 404 image Mar 7, 2024
@qudiqudi
Copy link
Author

qudiqudi commented Mar 7, 2024

Could be some sort of api/token limit...?

@timonsky
Copy link
Contributor

might be some problem with your search terms, eg. returning empty result set. see #125 and #128

@qudiqudi
Copy link
Author

I've only ever used the defaults, so I doubt that's the problem here. Looking at the issue tracker growing, this git might gonna be stale soon. I've removed this app from my instance, as I don't want to have unmaintained apps running on my personal server. Leaving this open though.

@newhinton
Copy link
Contributor

It is also possible that the public unsplash api finally stopped working. The new authenticated api is working already, but you'll need a token for it. I need to update the how-to for that. Also release the current master.

@cscgeiche
Copy link

cscgeiche commented Jul 17, 2024

The url for the api seems to have changed. There seems to be a new api for getting a random image but you need a api-token to access it. Maybe add a configuration-option for this and let users register at unsplash.
Dokumentation (Random Image): https://unsplash.com/documentation#get-a-random-photo
Dokumentation: https://unsplash.com/documentation

@newhinton
Copy link
Contributor

Can you check if this is present in 3.0.0 with the new authenticated api?

It is very likely that the original api was finally closed.

@newhinton newhinton added wontfix to be closed This indicates an older issue that may not be valid anymore Needs more Info This ticket requires more information to be worked on and removed bug labels Aug 31, 2024
@cscgeiche
Copy link

With the new API, it seems to work again. I would recommend removing the unauthenticated API from the dropdown.

@newhinton
Copy link
Contributor

Closed with v3.0.2. It will remove unsplash and fall back to a supported provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs more Info This ticket requires more information to be worked on to be closed This indicates an older issue that may not be valid anymore wontfix
Projects
None yet
Development

No branches or pull requests

4 participants