Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web update cannot continue after long backup #574

Open
blizzz opened this issue Jul 13, 2024 · 6 comments
Open

Web update cannot continue after long backup #574

blizzz opened this issue Jul 13, 2024 · 6 comments
Labels

Comments

@blizzz
Copy link
Member

blizzz commented Jul 13, 2024

Sometimes I am stuck at this position when using web updater:

Screenshot_20240713_220835

And Retry update would fail, because the reason is that the updater secret is meanwhile outdated:

Screenshot_20240713_220948

That is the same secret with which the previous "step 4" (download) succeeded. The previous backup step took 15.3s.

Something must have reset or deleted the updater secret in this process.

Opening the admin overview page and from there opening the updater again, let's me finish the update.

@joshtrichards
Copy link
Member

joshtrichards commented Jul 14, 2024

Something must have reset or deleted the updater secret in this process.

Did you happen to notice whether the updater.secret truly changed in your config.php in between those steps (but before coming back in via the Overview screen to reset)?

I looked into this recently based on a handful of mysterious reports from the forums (where I was able to gather enough log evidence to convince myself something like this was going on... at least in more than just a single isolated environment).

That led me to collect this: nextcloud/server#45714

Given the Updater itself is just a consumer of the configured updater.secret my assumption has been either:

  • it's changing when it's not supposed to be (in Server via the updatenotification app)
  • we're losing track of the current/correct one in the Updater itself or the browser side somehow (your experience suggests it's probably not the browser side)

@blizzz
Copy link
Member Author

blizzz commented Aug 1, 2024

Sorry, did not come round back to it, yet.

Did you happen to notice whether the updater.secret truly changed in your config.php in between those steps (but before coming back in via the Overview screen to reset)?

I checked before-after only.

That led me to collect this: nextcloud/server#45714

👍

we're losing track of the current/correct one in the Updater itself or the browser side somehow (your experience suggests it's probably not the browser side)

ack

it's changing when it's not supposed to be (in Server via the updatenotification app)

That's what I am thinking though I could not find a very obvious place so far.

@blizzz
Copy link
Member Author

blizzz commented Aug 29, 2024

for the record, i could not repro lately (while debug patch was applied).

@michaellass
Copy link

I faced this issue a couple of times now, last time when updating from 29.0.5 to 29.0.6. The update from 29.0.6 to 29.0.7 now went smoothly without this issue showing up. Was there a change that may have fixed this issue?

@joshtrichards
Copy link
Member

No, not specifically.

@michaellass
Copy link

No, not specifically.

I can now confirm that the update to 29.0.7 was a fluke. The issue appeared again when updating to 29.0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants