Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show header on mobile #134

Closed
juliusknorr opened this issue Jun 12, 2019 · 3 comments · Fixed by #972
Closed

Always show header on mobile #134

juliusknorr opened this issue Jun 12, 2019 · 3 comments · Fixed by #972
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working good first issue Good for newcomers

Comments

@juliusknorr
Copy link
Member

When using viewer on mobile devices the header is inaccessible as it is shown on hover. We should always show it though.
@juliusknorr juliusknorr added bug Something isn't working 1. to develop Accepted and waiting to be taken care of labels Jun 12, 2019
@szaimen

This comment has been minimized.

Sign in to view
@szaimen
Copy link
Contributor

szaimen commented Apr 12, 2021

@skjnldsv Would this be hard to implement? Do you have some pointers?

@skjnldsv
Copy link
Member

Use the isMobile mixin from the vue components and create a computed that set the clearViewDelay to -1 on those conditions

viewer/src/views/Viewer.vue

Line 29 in b3eb091

:clear-view-delay="isTesting ? -1 : 5000 /* prevent cypress timeouts */"

https://github.com/nextcloud/nextcloud-vue/blob/master/src/mixins/isMobile/index.js

@skjnldsv skjnldsv added the good first issue Good for newcomers label Apr 13, 2021
@szaimen szaimen mentioned this issue Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable header timeout on mobile nextcloud/viewer
3 participants
@juliusknorr @skjnldsv @szaimen