Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming does not work correct (Override issue?) #73

Closed
yirias opened this issue Dec 21, 2016 · 4 comments
Closed

Theming does not work correct (Override issue?) #73

yirias opened this issue Dec 21, 2016 · 4 comments

Comments

@yirias
Copy link

yirias commented Dec 21, 2016

Steps to reproduce

  1. Installed Nextcloud VM (Version 10) in Virtualbox
  2. Update Nextcloud to Version 11 using the delivered update.sh script
  3. Use the Theming App to theme Nextcloud

Expected behaviour

All colors, Links to the Cloud, Names and Logos should be the one's set in the Theming App.

Actual behaviour

Almost everything works fine, but the Favicon doesn't geht the set color and it does not change the logo. It stays the standard, blue Nextcloud Icon.

Server configuration

Server version: (see your admin page)
Ubuntu 16.4 LTS Server
Apache 2.4
PHP 7.0.8
MySQL 5.7.16

VM version
VirtualBox Version 5.1.12 r112440 (Qt5.6.2) running on a Windows 7 64Bit host

Updated from an older installed version or fresh install:
See above at ## Steps to reproduce

Logs (from today back to the December 16th)

https://hastebin.com/efomocojag.tex

Log file (/var/ncdata/nextcloud.log)

https://hastebin.com/ujezuvejup.tex

Installation log (command output)

I don't know how to get this, sorry.

By the way, I already wrote to the nexcloud.com forums. Maybe what I wrote there can help to.
See: https://help.nextcloud.com/t/different-theme-output-on-two-nextcloud-11-instances/6432?source_topic_id=4722

I also made a clean install of a new Nextcloud VM this morning. It behaves the same way, which means Theming does not work correctly.

I hope someone can help or clear things out to me.

Cheers yiria

@enoch85
Copy link
Member

enoch85 commented Dec 21, 2016

This is not a bug, this is per default. The favicon doesn't change afaik. Please make a request in https://github.com/nextcloud/server so the devs can add this option.

Thanks for a detailed issue!

@enoch85 enoch85 closed this as completed Dec 21, 2016
@yirias
Copy link
Author

yirias commented Dec 21, 2016

This is not a bug, this is per default. The favicon doesn't change afaik.

As far as I know it is a feature since Nextcloud 11. I have two instances running on public servers for testing and the Theming App works just as I mentioned in Expected behaviour including the change of the favicon. See https://ncdev.yiria.org for example. There is no extra theme folder, everything is done by the Theming App.

If I change the color, the color of the favicon changes, if I change the Logo, the Logo also changes in the favicon. This can also be seen in the source code I posted here: https://help.nextcloud.com/t/different-theme-output-on-two-nextcloud-11-instances/6432?source_topic_id=4722

If everything works well, the favicon should change. I can also see differences in the data folder of Nextcloud. On my public server there is a new folder appdata_##randomstring##/theming/##two_digit_number##/

It has the following files in it:

  • favIcon-core
  • favIcon-files
  • favIcon-settings
  • icon-core-filetypes_folder-shared.svg
  • icon-core-filetypes_folder.svg
  • icon-core-filetypes_x-office-document.svg

In the Nextcloud VM data folder, there are only these files:

  • icon-core-filetypes_application-pdf.svg
  • icon-core-filetypes_folder-external.svg
  • icon-core-filetypes_folder.svg
  • icon-core-filetypes_video.svg

The favicon files are missing and I don't get why.

Cheers yiria

@enoch85
Copy link
Member

enoch85 commented Dec 21, 2016

Please email me a admin login so that I can test. https://www.techandme.se/contact/

@yirias
Copy link
Author

yirias commented Dec 22, 2016

I just sent you an email, I hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants