-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix -dockerized execution #3137 #3148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The utilities adduser and addgroup are not part of the used container image Changed to useradd and groupadd anded their dependencies to Dockerfile Fix could not create plugins folder The permissions of /.nextflow were to restricted to Fix Typo and move comments to correct location Signed-off-by: Kirill Bulert <bulert@infai.org>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Kirill Bulert <bulert@infai.org>
Signed-off-by: Mike Lee <michael.lee0517@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Kirill Bulert <bulert@infai.org>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Kirill Bulert <bulert@infai.org>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Kirill Bulert <bulert@infai.org>
Signed-off-by: Kirill Bulert <bulert@infai.org>
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Kirill Bulert <bulert@infai.org>
pditommaso
reviewed
Aug 30, 2022
I messed, totally forget that this PR was still open and deleted my fork, since I was to lazy to resolve merge conflicts. Let's see what happens if I press reopen ...seriously embarrassed right now |
pditommaso
approved these changes
Nov 2, 2022
Thanks for this contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dockerize execution #3137
Amazon's Corretto docker image is missing basic user management utilities the entry script relies on.
Added utilities to Dockerfile
Fixed execution of nextflow within docker Container
Squash
The utilities adduser and addgroup are not installed inside the container image
Changed to useradd and groupadd added their dependencies to Dockerfile
Fix could not create plugins folder
The permissions of /.nextflow were to restricted to
Fix Typo and move comments to correct location
Test script