Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stale documentation in overview.md #4968

Merged
merged 2 commits into from
May 6, 2024

Conversation

greenberga
Copy link
Contributor

#4812 updated the syntax of the workflow in the example script to no longer use the | operator, but the accompanying description didn't change. This commit edits the description to bring it in line with the change in the workflow syntax.

@greenberga greenberga requested a review from a team as a code owner May 3, 2024 03:30
Copy link

netlify bot commented May 3, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit e875185
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/663796d1ad7ae20008c594e3
😎 Deploy Preview https://deploy-preview-4968--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bentsherman bentsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole thing is gonna be rewritten but the correction makes sense. Only clarify to refer to dependencies instead of order within the workflow block

docs/overview.md Outdated Show resolved Hide resolved
@greenberga
Copy link
Contributor Author

Thank you for clarifying!

greenberga and others added 2 commits May 5, 2024 10:25
nextflow-io#4812 updated the syntax of the workflow in the example script to no longer use the `|` operator, but the accompanying description didn't change. This commit edits the description to bring it in line with the change in the workflow syntax.

Signed-off-by: greenberga <38597857+greenberga@users.noreply.github.com>
Co-authored-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: greenberga <38597857+greenberga@users.noreply.github.com>
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks

@pditommaso pditommaso merged commit 6a58c6d into nextflow-io:master May 6, 2024
10 checks passed
pditommaso pushed a commit that referenced this pull request May 9, 2024

Signed-off-by: greenberga <38597857+greenberga@users.noreply.github.com>
Co-authored-by: Ben Sherman <bentshermann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants