Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed dsl=2 + error in example #4812

Merged
merged 4 commits into from Mar 13, 2024
Merged

Remove not needed dsl=2 + error in example #4812

merged 4 commits into from Mar 13, 2024

Conversation

mribeirodantas
Copy link
Member

@mribeirodantas mribeirodantas commented Mar 12, 2024

Signed-off-by: Marcel Ribeiro-Dantas mribeirodantas@seqera.io

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 8453a4e
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/65f0534410782c0008c78693
😎 Deploy Preview https://deploy-preview-4812--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/basic.md Outdated Show resolved Hide resolved
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit d95c7bb
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/65f1b8321a7e8900089640df
😎 Deploy Preview https://deploy-preview-4812--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Marcel Ribeiro-Dantas <mribeirodantas@seqera.io>
@mribeirodantas
Copy link
Member Author

@ewels what about now? 😄

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍🏻 Loses the chaining syntax due to the multiple inputs, but I think it's good not to introduce bad practices on what could be people's first view of a pipeline script.

Thanks @mribeirodantas! Ok to merge @pditommaso ?

@pditommaso
Copy link
Member

Vamos

@pditommaso pditommaso merged commit 7c5779d into master Mar 13, 2024
22 checks passed
@pditommaso pditommaso deleted the minor_fixes branch March 13, 2024 15:54
nschan pushed a commit to nschan/nextflow that referenced this pull request Apr 3, 2024
Signed-off-by: Marcel Ribeiro-Dantas <mribeirodantas@seqera.io>
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan pushed a commit to nschan/nextflow that referenced this pull request Apr 3, 2024
Signed-off-by: Marcel Ribeiro-Dantas <mribeirodantas@seqera.io>
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
greenberga added a commit to greenberga/nextflow that referenced this pull request May 3, 2024
nextflow-io#4812 updated the syntax of the workflow in the example script to no longer use the `|` operator, but the accompanying description didn't change. This commit edits the description to bring it in line with the change in the workflow syntax.

Signed-off-by: greenberga <38597857+greenberga@users.noreply.github.com>
greenberga added a commit to greenberga/nextflow that referenced this pull request May 5, 2024
nextflow-io#4812 updated the syntax of the workflow in the example script to no longer use the `|` operator, but the accompanying description didn't change. This commit edits the description to bring it in line with the change in the workflow syntax.

Signed-off-by: greenberga <38597857+greenberga@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants