actions/shellcheck: Check GitHub Actions composite actions too #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocal Avoids scope pollution; noticed when I was about to add a similar function with a "tmpdir" variable itself.
…eps… …in preparation for adding support for composite action files too. Composite actions are kind of like a single job in a workflow, so we'll use the same logic for handling them. Diff best viewed with whitespace ignored.
…actions too Covers an area we were previously missing. Composite actions have steps just like a job in a workflow, so we can treat them similarly.
… defined By default it already assumes UPPERCASE vars are always defined externally, but it will warn about lowercase vars that it doesn't know about. Resolves a warning about the use of a "runtime" env var in actions/setup-nextstrain-cli.
tsibley
force-pushed
the
trs/shellcheck-actions-too
branch
from
ad2945f
to
8a0a372
Compare
…ia the shebang This lets it properly detect when modes like "errexit" (i.e. `set -e`) and "pipefail" are enabled via the shell invocation. Resolves a false warning in a Nextstrain CLI action that uses `pushd` without checking exit code (because `-e` is in the shell invocation so checking is unnecessary). Disables a couple of warnings that pertain to the shebang, which are fine to ignore because we're generating it just to hint ShellCheck.
|
Incidentally, this work also led me to identify a bug in ShellCheck's handling of shebangs: the regex used to check for |
genehack
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Checklist