pathogen-repo-ci: Keep running even if one of the pathogen workflows fails #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fails In testing it's helpful to report all test results even in the face of an early failure to reduce the chances of playing whack-a-mole with unreported failures once when you fix the first failure. For example, we want to know if the phylogenetic workflow fails even when the ingest workflow run before it fails.
joverlee521
approved these changes
Jun 14, 2024
|
Hmm,
I wish I'd realized this a minute earlier. I think I can swap around implementation to have our cake and eat it too. |
tsibley
added a commit
that referenced
this pull request
Jun 14, 2024
…tinue-on-error: true While "continue-on-error: true" resulted in the behaviour we wanted, it also meant the job step status indicators were misleading: even when an ingest/phylogenetic/nextclade step failed, the UI showed a check mark for them in the logs. Instead of masking failures to keep going in the face of errors, override the default success() conditional by specifying our own conditions on a status expression. Related-to: <#98 (comment)>
Merged
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing it's helpful to report all test results even in the face of an early failure to reduce the chances of playing whack-a-mole with unreported failures once when you fix the first failure. For example, we want to know if the phylogenetic workflow fails even when the ingest workflow run before it fails.
Checklist