pathogen-repo-ci: Use status functions in conditionals instead of continue-on-error: true #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tinue-on-error: true While "continue-on-error: true" resulted in the behaviour we wanted, it also meant the job step status indicators were misleading: even when an ingest/phylogenetic/nextclade step failed, the UI showed a check mark for them in the logs. Instead of masking failures to keep going in the face of errors, override the default success() conditional by specifying our own conditions on a status expression. Related-to: <#98 (comment)>
|
and still works with no valid workflows and two valid workflows. I wish we had testing of that in CI for this repo so I didn't have to keep manually triggering them, but that cracks the lid on another kettle of fish, so I won't for now. |
tsibley
requested review from
joverlee521 and
genehack
and removed request for
joverlee521
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While "continue-on-error: true" resulted in the behaviour we wanted, it also meant the job step status indicators were misleading: even when an ingest/phylogenetic/nextclade step failed, the UI showed a check mark for them in the logs. Instead of masking failures to keep going in the face of errors, override the default success() conditional by specifying our own conditions on a status expression.
Related-to: #98 (comment)
Checklist