Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

augur align parameter fill_gaps works now, even if no reference is provided #466

Merged
merged 1 commit into from Mar 28, 2020
Merged

augur align parameter fill_gaps works now, even if no reference is provided #466

merged 1 commit into from Mar 28, 2020

Conversation

tolot27
Copy link
Contributor

@tolot27 tolot27 commented Mar 24, 2020

Fixes #462 and is related to #465 in such a way that it reduces the back writing of the alignment file to only one.

Newly introduced doctests have been adapted and passing successful.

@tolot27 tolot27 mentioned this pull request Mar 24, 2020
Merged
@huddlej huddlej added this to In Review in Bioinformatics work via automation Mar 25, 2020
huddlej
huddlej approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! Thank you for resolving this issue, @tolot27!

@huddlej huddlej merged commit d60ce5a into nextstrain:master Mar 28, 2020
Bioinformatics work automation moved this from In Review to Done Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huddlej huddlej huddlej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Bioinformatics work
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fill_gaps without reference name
2 participants
@tolot27 @huddlej