[WIP] Add tests for clades and add black code format #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 on using black. |
|
@willingc I'm just following up since this was labeled as a work in progress. Do you have any other changes you'd like to make to this PR before we flag it as ready for review? I love the idea of using something like black, but coding style has been a contentious subject internally and we should probably split this into two PRs: one for clade tests and another for coding style automation. Are you available to help split those PRs? If not, we can also manage this from our end. Thank you again for your work here (and generally with augur)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test file for clades and a sample data file.
The PR edits the code style to use black formatter. Black gives a project consistency
and smaller PR diffs.
Related to #476