Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter: Report min and max date separately #930

Merged

Conversation

victorlin
Copy link
Member

Description of proposed changes

This allows for more detail in the report, and makes it more consistent by having one report line per parameter.

Motivated by work in #854.

Related issue(s)

N/A

Testing

Added cram test to verify new output.

@victorlin victorlin requested a review from a team May 17, 2022 17:07
@victorlin victorlin self-assigned this May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #930 (1cdde92) into master (9dda176) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   59.59%   59.63%   +0.03%     
==========================================
  Files          43       43              
  Lines        6056     6062       +6     
  Branches     1550     1551       +1     
==========================================
+ Hits         3609     3615       +6     
  Misses       2188     2188              
  Partials      259      259              
Impacted Files Coverage Δ
augur/filter.py 96.35% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dda176...1cdde92. Read the comment docs.

Copy link
Contributor

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a great UI improvement. It's also great to see how the intended modularity of the filter functions worked out for this kind of change.

This allows for more detail in the report, and makes it more consistent by having one report line per parameter.
@victorlin victorlin force-pushed the filter/report-min-max-date-separately branch from 640b53a to 1cdde92 Compare May 24, 2022 18:54
@victorlin victorlin merged commit 99c4d05 into nextstrain:master May 24, 2022
@victorlin victorlin deleted the filter/report-min-max-date-separately branch May 24, 2022 19:05
@victorlin victorlin added this to the Major release 16.0.0 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants