Skip to content

Commit

Permalink
Make dataset loading more consistent
Browse files Browse the repository at this point in the history
These changes were motivated by
[#1283](#1283) which arose
as we used different code paths for loading a dataset viz and a
narrative.

Here we represent each dataset by a `Dataset` object. This is used for
stand alone datasets, each dataset in a tangletree, and each dataset in
a narrative. Each dataset instance describes the various API endpoints
of datafiles for each dataset, manages fetching of these datafiles and,
where appropriate, can dispatch data to update redux state.

This has been tested on various single datasets, tangle-trees, and
narratives in this repo. Notably, this commit breaks narratives with
multiple datasets; this will be fixed in a subsequent commit to
reflect Eli's work in PR #1312.
  • Loading branch information
jameshadfield committed Aug 11, 2021
1 parent 9a9bf2d commit c190057
Show file tree
Hide file tree
Showing 4 changed files with 260 additions and 308 deletions.
3 changes: 2 additions & 1 deletion narratives/test_sidecar-files.md
Expand Up @@ -44,6 +44,7 @@ A tanglegram of Vic and H3N2 makes little sense, but we should see the trees lin

The left tree (Vic) should be coloured teal. When reloading the page this should initially flash grey.

We should also see _both_ the entropy and the frequencies panel. The latter may take a moment to arrive when refreshing the page.
The URL specifies that we should also see _both_ the entropy and the frequencies panel,
however this functionality does not yet exist in Nextstrain narratives when viewing a tangletree.

#### Checklist: refresh the page from this slide

0 comments on commit c190057

Please sign in to comment.