runner.conda: Explicitly get latest main version
#280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsibley
requested changes
May 10, 2023
joverlee521
force-pushed
the
fix-conda-latest
branch
from
e71c006
to
a37b4d3
Compare
|
Looks like some new CI errors from type checking and linting. |
tsibley
requested changes
May 12, 2023
joverlee521
force-pushed
the
fix-conda-latest
branch
from
a37b4d3
to
6128f0b
Compare
Learned through the conda-base repo's CI job that Anaconda's
`/release/{owner_login}/{package_name}/latest` API endpoint returns the
latest package version regardless of labels.¹ This means that users can
accidentally install test versions of the nextstrain-base package.
I tried various endpoints from the API docs² to see if we can pass the
label as a URL param that can allow the filtering to be done on server,
but there were no leads in the docs and nothing I tried worked.
So this commit adds an explicit check for the latest `main` version
by pulling all package files and then filtering for the label and
finding the max `version`.
If the check for the latest `main` version fails, then this will return
to the previous behavior of using `latest` with a warning that the
latest version will be used regardless of label.
¹ nextstrain/conda-base#26
² https://api.anaconda.org/docs
@tsibley noted in review that the `/release...` API endpoint can actually include one release per subdir per build when there are multiple builds. This commit explicitly finds the max `build_number` for available distributions so that users are installing the latest build.
joverlee521
force-pushed
the
fix-conda-latest
branch
from
6128f0b
to
21f2945
Compare
tsibley
approved these changes
May 22, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learned through the conda-base repo's CI job that Anaconda's
/release/{owner_login}/{package_name}/latestAPI endpoint returns the latest package version regardless of labels.¹ This means that users can accidentally install test versions of the nextstrain-base package.I tried various endpoints from the API docs² to see if we can pass the label as a URL param that can allow the filtering to be done on server, but there were no leads in the docs and nothing I tried worked. So this commit adds an explicit check for the latest
mainversion by pulling all package files and then filtering for the label and finding the maxupload_time.¹ nextstrain/conda-base#26 ² https://api.anaconda.org/docs
Testing