remote: Show more possible reasons for S3 access error #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, other reasons detailed in the changes would show an error message saying "no bucket exists" even if it does exist. Update the error text to describe more possible reasons based on docs for S3.Client.head_bucket.¹ and local testing. This list might not be exhaustive, but I can't come up with any other scenarios. ¹ <https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3/client/head_bucket.html>
joverlee521
approved these changes
Jan 4, 2024
jameshadfield
approved these changes
Jan 4, 2024
|
This PR will close #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Previously, other reasons detailed in the changes would show an error message saying "no bucket exists" even if it does exist.
Update the error text to describe more possible reasons based on docs for S3.Client.head_bucket.¹ and local testing. This list might not be exhaustive, but I can't come up with any other scenarios.
¹ https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3/client/head_bucket.html
Related issue(s)
Checklist