Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display friendly country names and flags #27

Merged
merged 11 commits into from
Sep 27, 2023

Conversation

ivan-aksamentov
Copy link
Member

@ivan-aksamentov ivan-aksamentov commented Sep 25, 2023

  • convert country codes into country names when displaying
  • ensure that all country flags are displayed
  • ensure that all regions flags are displayed
  • extract countries, regions and variant names for translations
  • update translations (in separate PR to reduce clutter in diffs)

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
flu-frequencies ✅ Ready (Inspect) Visit Preview Sep 25, 2023 4:37pm

@ivan-aksamentov ivan-aksamentov changed the title Display, friendly country names and flags Display friendly country names and flags Sep 25, 2023
@huddlej
Copy link
Contributor

huddlej commented Sep 25, 2023

🚀 I love these improvements, @ivan-aksamentov!

Would it be possible to sort the countries by their names instead of their codes? For example, I'd expect South Korea and South Africa to be placed next to each other in the list of countries.

@ivan-aksamentov
Copy link
Member Author

@huddlej Yes, I think so. Richard also requested sorting of variants in the side panel. So I am going to look into sorting in general.

@ivan-aksamentov ivan-aksamentov merged commit 55fd3cb into master Sep 27, 2023
1 check passed
@ivan-aksamentov ivan-aksamentov deleted the feat/web-friendly-country-names branch September 27, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants