Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] nextstrain build with Docker using multicore #384

Closed
TrentBrick opened this issue Apr 29, 2020 · 2 comments
Closed

[Feature request] nextstrain build with Docker using multicore #384

TrentBrick opened this issue Apr 29, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@TrentBrick
Copy link

Given that the number of SARS-Cov-2 sequences is increasing so rapidly I want to use multicore to run my analysis.

I found with Nextstrain CLI the call to snakemake allows for --cores 8 to set the number of desired cores.

But could not find similar documentation for using Nextstrain with Docker. I got it working with nextstrain build . --cores 8 but also had to be sure to allow my Docker environment to use this number of cores. These things were both found through trial and error. Sorry if there is some clear documentation I missed here but in case there isn't I wanted to flag that there should be somewhere.

Thank you.

@TrentBrick TrentBrick added the enhancement New feature or request label Apr 29, 2020
@tsibley
Copy link
Member

tsibley commented May 1, 2020

@TrentBrick Thanks for the feedback! The interaction of options can indeed be confusing, but we'd definitely like to improve our documentation.

We're in the process of improving how the build works to make it easier for other folks, like yourself, to run it. Part of this is a re-organization of the workflow and the other part is more docs. I do think this particular point of confusion will be addressed by that effort.

@trvrb
Copy link
Member

trvrb commented Jan 21, 2021

We've updated parameters specifying cores in ncov. We now use a snakemake config.yaml file that takes an option for cores. https://github.com/nextstrain/ncov/blob/master/my_profiles/example/config.yaml#L18 I think this resolves this issue. Will close now, but could be re-opened.

@trvrb trvrb closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants