fix: Quote "3.10" in rebuild-100k.yml to prevent parsing as decimal #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that YAML interprets values like 3.10 as decimals, instead of strings (https://yaml.org/spec/1.2.2/#24-tags) So we need to put version strings in quotes in things like `python-version: "3.10"` Bug where this was root cause: ncov rebuild-100k workflow: https://github.com/nextstrain/ncov/blob/8765cd96660f2a0a923074886899ebda678abc89/.github/workflows/rebuild-100k.yml#L18 https://github.com/nextstrain/ncov/actions/runs/4721332745/jobs/8374484699#step:3:7 Things seem to have fine while we didn’t use Python version 3.10 as unquoted 3.9 is still 3.9 and cast back to string “3.9”. But trailing 0 gets chopped off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that YAML interprets values like 3.10 as decimals, instead of strings (https://yaml.org/spec/1.2.2/#24-tags) So we need to put version strings in quotes in things like
python-version: "3.10"Bug where this was root cause: ncov rebuild-100k workflow:ncov/.github/workflows/rebuild-100k.yml
Line 18 in 8765cd9
Things seem to have fine while we didn’t use Python version 3.10 as unquoted 3.9 is still 3.9 and cast back to string “3.9”. But trailing 0 gets chopped off.
Testing