Create locations DataFrame with a strain index #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up fix to 2ec3135. Prior to that commit, DataFrames were not indexed by strain and used the default counter index. The concat relied on both the locations and metadata DataFrames having the same counter index. This was broken in the linked commit when the metadata was switched to index on strain. Solutions are to either (1) revert to using counter index for both, (2) use strain index for both, or (3) ignore the index when concatenating. A strain index has benefits and is used elsewhere in the script, so this commit implements solution (2).
|
Merging because this works for myself and another user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Prior to that commit, DataFrames were not indexed by strain and used the
default counter index. The concat relied on both the locations and
metadata DataFrames having the same counter index. This was broken in
the linked commit when the metadata was switched to index on strain.
Solutions are to either (1) revert to using counter index for both, (2)
use strain index for both, or (3) ignore the index when concatenating.
A strain index has benefits and is used elsewhere in the script, so this
commit implements solution (2).
Related issue(s)
Follow-up to #1062
Testing
What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Release checklist
If this pull request introduces backward incompatible changes, complete the following steps for a new release of the workflow:
docs/src/reference/change_log.mdin this pull request to document these changes and the new version number.If this pull request introduces new features, complete the following steps:
docs/src/reference/change_log.mdin this pull request to document these changes by the date they were added.