feat: attempt to switch table to react-table + react-window #81
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| Header: 'Sequence', | ||
| Cell({ cell, row }) { | ||
| const sequence = row.original |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
| { | ||
| Header: 'Sequence', | ||
| Cell({ cell, row }) { | ||
| const sequence = row.original |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Unsafe member access .original on an any value. @typescript-eslint/no-unsafe-member-access
| Header: 'Sequence', | ||
| Cell({ cell, row }) { | ||
| const sequence = row.original | ||
| return <ColumnName {...cell.getCellProps()} seqName={sequence.seqName} sequence={sequence} /> |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Unsafe member access .getCellProps on an any value. @typescript-eslint/no-unsafe-member-access
| Header: 'Sequence', | ||
| Cell({ cell, row }) { | ||
| const sequence = row.original | ||
| return <ColumnName {...cell.getCellProps()} seqName={sequence.seqName} sequence={sequence} /> |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
| Header: 'Sequence', | ||
| Cell({ cell, row }) { | ||
| const sequence = row.original | ||
| return <ColumnName {...cell.getCellProps()} seqName={sequence.seqName} sequence={sequence} /> |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
| Header: 'Sequence', | ||
| Cell({ cell, row }) { | ||
| const sequence = row.original | ||
| return <ColumnName {...cell.getCellProps()} seqName={sequence.seqName} sequence={sequence} /> |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Unsafe member access .seqName on an any value. @typescript-eslint/no-unsafe-member-access
| Header: 'Sequence', | ||
| Cell({ cell, row }) { | ||
| const sequence = row.original | ||
| return <ColumnName {...cell.getCellProps()} seqName={sequence.seqName} sequence={sequence} /> |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
| <tr className="results-table-row" key={seqName}> | ||
| <ColumnName seqName={seqName} sequence={sequence} /> | ||
| <td colSpan={7} className="results-table-col results-table-col-clade" /> | ||
| <tr {...row.getRowProps({ style })}> |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
| {headers.map((column) => { | ||
| // console.log({ column }) | ||
| return ( | ||
| <div {...column.getHeaderProps()} className="th"> |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Missing "key" prop for element in iterator react/jsx-key
|
Abandoning this idea, because react-table column-oriented design does not work well for us. Also, I no longer see any advantages of using it. |
This is an ongoing work on replacing the plain
<table/>on results page.The plan is to: