-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: virtualize table #95
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/neherlab/nextclade/9jesd6f8v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
packages/web/src/components/Results/ResultsTable_.tsx|8 col 8| 'AutoSizer' is defined but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/Results/ResultsTable_.tsx|24 col 8| No default export found in imported module "react-resize-detector". import/default
packages/web/src/components/Results/ResultsTable_.tsx|27 col 13| Component definition is missing display name react/display-name
packages/web/src/components/Results/ResultsTable_.tsx|29 col 18| 'style' is assigned a value but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/Results/ResultsTable_.tsx|30 col 9| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|30 col 11| 'status' is assigned a value but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/Results/ResultsTable_.tsx|30 col 57| Unsafe member access [index] on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/Results/ResultsTable_.tsx|30 col 62| Computed name [index] resolves to an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/Results/ResultsTable_.tsx|32 col 7| Unsafe member access .length on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/Results/ResultsTable_.tsx|34 col 28| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|35 col 30| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|35 col 49| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|45 col 28| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|46 col 30| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|46 col 49| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|53 col 26| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|54 col 28| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|54 col 47| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|55 col 33| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|56 col 30| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|57 col 34| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|58 col 34| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|59 col 32| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|60 col 29| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|62 col 28| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|62 col 47| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|91 col 3| Assignment to function parameter 'result'. no-param-reassign
packages/web/src/components/Results/ResultsTable_.tsx|112 col 13| Unexpected console statement. no-console
packages/web/src/components/Results/ResultsTable_.tsx|112 col 27| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|112 col 34| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|125 col 37| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|125 col 52| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/SequenceView/SequenceView.tsx|4 col 8| 'AutoSizer' is defined but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/SequenceView/SequenceView.tsx|69 col 65| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|2 col 10| 'render' is defined but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/StickyGrid/StickyGrid.jsx|8 col 3| Unsafe return of an any typed value @typescript-eslint/no-unsafe-return
packages/web/src/components/StickyGrid/StickyGrid.jsx|8 col 3| Unsafe member access .reduce on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|8 col 3| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|11 col 9| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|11 col 9| Assignment to function parameter 'minRow'. no-param-reassign
packages/web/src/components/StickyGrid/StickyGrid.jsx|14 col 9| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|14 col 9| Assignment to function parameter 'maxRow'. no-param-reassign
packages/web/src/components/StickyGrid/StickyGrid.jsx|17 col 9| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|17 col 9| Assignment to function parameter 'minColumn'. no-param-reassign
packages/web/src/components/StickyGrid/StickyGrid.jsx|20 col 9| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|20 col 9| Assignment to function parameter 'maxColumn'. no-param-reassign
packages/web/src/components/StickyGrid/StickyGrid.jsx|23 col 7| Unsafe return of an any[] typed value @typescript-eslint/no-unsafe-return
packages/web/src/components/StickyGrid/StickyGrid.jsx|31 col 3| loops are not allowed no-loops/no-loops
packages/web/src/components/StickyGrid/StickyGrid.jsx|31 col 12| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|31 col 43| Unary operator '++' used. no-plusplus
packages/web/src/components/StickyGrid/StickyGrid.jsx|33 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|34 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|36 col 28| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|46 col 3| loops are not allowed no-loops/no-loops
packages/web/src/components/StickyGrid/StickyGrid.jsx|46 col 12| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|46 col 37| Unary operator '++' used. no-plusplus
packages/web/src/components/StickyGrid/StickyGrid.jsx|48 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|49 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|51 col 28| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|58 col 7| 'GridColumn' is assigned a value but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/StickyGrid/StickyGrid.jsx|60 col 55| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|68 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|69 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|71 col 29| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|79 col 10| Unsafe member access .map on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|79 col 10| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|80 col 87| Do not use Array index in keys react/no-array-index-key
packages/web/src/components/StickyGrid/StickyGrid.jsx|80 col 87| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|91 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|92 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|93 col 28| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|98 col 8| Unsafe member access .map on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|98 col 8| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|99 col 78| Do not use Array index in keys react/no-array-index-key
packages/web/src/components/StickyGrid/StickyGrid.jsx|99 col 78| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|110 col 30| Component definition is missing display name react/display-name
packages/web/src/components/StickyGrid/StickyGrid.jsx|113 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|114 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|114 col 29| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|115 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|115 col 28| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|116 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 19| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 19| Operands of '+' operation must either be both strings or both numbers. @typescript-eslint/restrict-plus-operands
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 19| Prefer Number.parseFloat()
over parseFloat()
. unicorn/prefer-number-properties
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 30| Unsafe member access .width on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 20| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 20| Operands of '+' operation must either be both strings or both numbers. @typescript-eslint/restrict-plus-operands
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 20| Prefer Number.parseFloat()
over parseFloat()
. unicorn/prefer-number-properties
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 31| Unsafe member access .height on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|121 col 41| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|122 col 40| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|122 col 59| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|126 col 40| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|126 col 69| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|126 col 96| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|127 col 32| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|127 col 60| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|127 col 87| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|138 col 7| 'StickyGrid' is assigned a value but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/StickyGrid/StickyGrid.jsx|141 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|142 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|143 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|144 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|149 col 24| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|149 col 48| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
packages/web/src/components/Results/ResultsTable_.tsx|46 col 49| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|53 col 26| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|54 col 28| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|54 col 47| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|55 col 33| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|56 col 30| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|57 col 34| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|58 col 34| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|59 col 32| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|60 col 29| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|62 col 28| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|62 col 47| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|91 col 3| Assignment to function parameter 'result'. no-param-reassign
packages/web/src/components/Results/ResultsTable_.tsx|112 col 13| Unexpected console statement. no-console
packages/web/src/components/Results/ResultsTable_.tsx|112 col 27| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|112 col 34| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|125 col 37| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/Results/ResultsTable_.tsx|125 col 52| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/SequenceView/SequenceView.tsx|4 col 8| 'AutoSizer' is defined but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/SequenceView/SequenceView.tsx|69 col 65| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|2 col 10| 'render' is defined but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/StickyGrid/StickyGrid.jsx|8 col 3| Unsafe return of an any typed value @typescript-eslint/no-unsafe-return
packages/web/src/components/StickyGrid/StickyGrid.jsx|8 col 3| Unsafe member access .reduce on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|8 col 3| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|11 col 9| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|11 col 9| Assignment to function parameter 'minRow'. no-param-reassign
packages/web/src/components/StickyGrid/StickyGrid.jsx|14 col 9| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|14 col 9| Assignment to function parameter 'maxRow'. no-param-reassign
packages/web/src/components/StickyGrid/StickyGrid.jsx|17 col 9| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|17 col 9| Assignment to function parameter 'minColumn'. no-param-reassign
packages/web/src/components/StickyGrid/StickyGrid.jsx|20 col 9| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|20 col 9| Assignment to function parameter 'maxColumn'. no-param-reassign
packages/web/src/components/StickyGrid/StickyGrid.jsx|23 col 7| Unsafe return of an any[] typed value @typescript-eslint/no-unsafe-return
packages/web/src/components/StickyGrid/StickyGrid.jsx|31 col 3| loops are not allowed no-loops/no-loops
packages/web/src/components/StickyGrid/StickyGrid.jsx|31 col 12| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|31 col 43| Unary operator '++' used. no-plusplus
packages/web/src/components/StickyGrid/StickyGrid.jsx|33 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|34 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|36 col 28| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|46 col 3| loops are not allowed no-loops/no-loops
packages/web/src/components/StickyGrid/StickyGrid.jsx|46 col 12| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|46 col 37| Unary operator '++' used. no-plusplus
packages/web/src/components/StickyGrid/StickyGrid.jsx|48 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|49 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|51 col 28| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|58 col 7| 'GridColumn' is assigned a value but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/StickyGrid/StickyGrid.jsx|60 col 55| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|68 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|69 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|71 col 29| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|79 col 10| Unsafe member access .map on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|79 col 10| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|80 col 87| Do not use Array index in keys react/no-array-index-key
packages/web/src/components/StickyGrid/StickyGrid.jsx|80 col 87| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|91 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|92 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|93 col 28| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|98 col 8| Unsafe member access .map on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|98 col 8| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|99 col 78| Do not use Array index in keys react/no-array-index-key
packages/web/src/components/StickyGrid/StickyGrid.jsx|99 col 78| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|110 col 30| Component definition is missing display name react/display-name
packages/web/src/components/StickyGrid/StickyGrid.jsx|113 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|114 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|114 col 29| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|115 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|115 col 28| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|116 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 19| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 19| Operands of '+' operation must either be both strings or both numbers. @typescript-eslint/restrict-plus-operands
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 19| Prefer Number.parseFloat()
over parseFloat()
. unicorn/prefer-number-properties
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 30| Unsafe member access .width on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 20| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 20| Operands of '+' operation must either be both strings or both numbers. @typescript-eslint/restrict-plus-operands
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 20| Prefer Number.parseFloat()
over parseFloat()
. unicorn/prefer-number-properties
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 31| Unsafe member access .height on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|121 col 41| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|122 col 40| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|122 col 59| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|126 col 40| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|126 col 69| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|126 col 96| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|127 col 32| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|127 col 60| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|127 col 87| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|138 col 7| 'StickyGrid' is assigned a value but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/StickyGrid/StickyGrid.jsx|141 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|142 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|143 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|144 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|149 col 24| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|149 col 48| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
packages/web/src/components/StickyGrid/StickyGrid.jsx|34 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|36 col 28| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|46 col 3| loops are not allowed no-loops/no-loops
packages/web/src/components/StickyGrid/StickyGrid.jsx|46 col 12| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|46 col 37| Unary operator '++' used. no-plusplus
packages/web/src/components/StickyGrid/StickyGrid.jsx|48 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|49 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|51 col 28| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|58 col 7| 'GridColumn' is assigned a value but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/StickyGrid/StickyGrid.jsx|60 col 55| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|68 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|69 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|71 col 29| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|79 col 10| Unsafe member access .map on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|79 col 10| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|80 col 87| Do not use Array index in keys react/no-array-index-key
packages/web/src/components/StickyGrid/StickyGrid.jsx|80 col 87| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|91 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|92 col 5| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|93 col 28| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|98 col 8| Unsafe member access .map on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|98 col 8| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|99 col 78| Do not use Array index in keys react/no-array-index-key
packages/web/src/components/StickyGrid/StickyGrid.jsx|99 col 78| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|110 col 30| Component definition is missing display name react/display-name
packages/web/src/components/StickyGrid/StickyGrid.jsx|113 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|114 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|114 col 29| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|115 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|115 col 28| Unsafe call of an any typed value. @typescript-eslint/no-unsafe-call
packages/web/src/components/StickyGrid/StickyGrid.jsx|116 col 13| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 19| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 19| Operands of '+' operation must either be both strings or both numbers. @typescript-eslint/restrict-plus-operands
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 19| Prefer Number.parseFloat()
over parseFloat()
. unicorn/prefer-number-properties
packages/web/src/components/StickyGrid/StickyGrid.jsx|118 col 30| Unsafe member access .width on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 20| Invalid type "any" of template literal expression. @typescript-eslint/restrict-template-expressions
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 20| Operands of '+' operation must either be both strings or both numbers. @typescript-eslint/restrict-plus-operands
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 20| Prefer Number.parseFloat()
over parseFloat()
. unicorn/prefer-number-properties
packages/web/src/components/StickyGrid/StickyGrid.jsx|119 col 31| Unsafe member access .height on an any value. @typescript-eslint/no-unsafe-member-access
packages/web/src/components/StickyGrid/StickyGrid.jsx|121 col 41| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|122 col 40| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|122 col 59| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|126 col 40| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|126 col 69| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|126 col 96| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|127 col 32| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|127 col 60| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|127 col 87| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|138 col 7| 'StickyGrid' is assigned a value but never used. @typescript-eslint/no-unused-vars
packages/web/src/components/StickyGrid/StickyGrid.jsx|141 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|142 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|143 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|144 col 7| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|149 col 24| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
packages/web/src/components/StickyGrid/StickyGrid.jsx|149 col 48| Unsafe assignment of an any value. @typescript-eslint/no-unsafe-assignment
Resolves #40, resolves #35
This puts table into a virtualized (windowed) container (using react-window). This technique ensures that only visible rows are rendered (plus a given number of "overscan" rows) an thus reduces load on rendering thread, makes application more responsive and improves user experience.
Theoretically, there is no limit on number of rows we can put into the virtualized table. This is important for being able to process large datasets.
This modification comes with significant changes in markup and styling of the table. Notably, we no longer use conventional
<table>
tags, but ratherdiv
s with some very tricky flexbox styling.<table>
just plain does not work with react-window, and flexbox seemed like an obvious second choice.Several workarounds have to be added in order to implement fixed header row. Even though its content fits into available space, it has it's own vertical scrollbar, just to ensure that it will be shifted by the same amount of pixels as the table body, which always has a scrollbar. We need to find a way to make header's scrollbar invisible.
This also prepares grounds for more comfortable implementation of #25
Follow-up: