Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Install nextstrain.sphinx.theme extension #574

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Jul 18, 2022

Description of proposed changes

The new extension has sphinx_copybutton pre-installed and configured. This change enables it here.
This also makes it easier to configure other extensions across multiple docs projects.

Related issue(s)

nextstrain/sphinx-theme#30

Testing

  • copy button works on RTD preview build

@victorlin victorlin self-assigned this Jul 18, 2022
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-victorlin--4sbojr July 18, 2022 23:40 Inactive
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-victorlin--4sbojr July 18, 2022 23:51 Inactive
@tsibley tsibley self-requested a review July 27, 2022 22:11
Copy link
Member

@tsibley tsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but collapse the commits together since they're co-dependent?

The new extension has sphinx_copybutton pre-installed and configured. This change enables it here.
This also makes it easier to configure other extensions across multiple docs projects.

Bump nextstrain-sphinx-theme to >=2022.5 since this is when the extension started being actively configured.
@victorlin victorlin force-pushed the victorlin/docs-install-nextstrain-extension branch from aeb5794 to 199619e Compare July 27, 2022 23:28
@victorlin victorlin merged commit ea425e4 into master Jul 27, 2022
@victorlin victorlin deleted the victorlin/docs-install-nextstrain-extension branch July 27, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants