Improve server startup messages #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
requested changes
Apr 12, 2024
victorlin
force-pushed
the
james/server-startup-message
branch
from
2d8569f
to
433a14c
Compare
jameshadfield
added a commit
that referenced
this pull request
Apr 23, 2024
The server is now often _not_ running at nextstrain.org; the core team runs additional dev + canary servers, we have heroku review apps as well as external groups who run our server. And I presume most of the people reading the startup message are actually running locally. See <#826 (comment)> for further discussion.
jameshadfield
added a commit
that referenced
this pull request
Apr 23, 2024
We use Promise.allSettled in the expectation that the server will eventually call multiple async functions and we want to settle them all before printing the message. The AWS info is not displayed when using our server as a "groups server", as per commentary in <#826 (comment)>
jameshadfield
force-pushed
the
james/server-startup-message
branch
from
433a14c
to
c6b0315
Compare
victorlin
requested changes
Apr 23, 2024
tsibley
changed the title
tsibley
requested changes
Apr 24, 2024
jameshadfield
added a commit
that referenced
this pull request
Apr 29, 2024
We attempt to report the IAM user (or ARN) for any provided AWS credentials. See review commentary in <#826> for why this is desirable for all users, including those who are using the "Nextstrain groups" server.
jameshadfield
force-pushed
the
james/server-startup-message
branch
from
c6b0315
to
6fb22f4
Compare
tsibley
requested changes
May 1, 2024
In preparation for upcoming additions. The additions will require async calls so we add a simple log statement at the earliest time the server is actually listening which may be helpful for certain debugging situations.
The server is now often _not_ running at nextstrain.org; the core team runs additional dev + canary servers, we have Heroku review apps as well as external groups who run our server. (And I presume most of the people reading the startup message are actually running locally.)
We attempt to report the IAM user (or ARN) for any provided AWS credentials. See review commentary in <#826> for why this is desirable for all users, including those who are using the "Nextstrain groups" server.
The server requires us to specify a file defining available groups, but this is env / config defined and so changes depending on the environment. Printing a brief summary is helpful for debugging / reminding ourselves what groups are in play.
jameshadfield
force-pushed
the
james/server-startup-message
branch
from
6fb22f4
to
2eb9605
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #685
@victorlin could you take a look at this, especially with how it may pertain to someone running the server as a groups app?