config/clades: remove excess whitespace #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered as part of nextstrain/augur#1293 that the clade TSVs for this repo has excess whitespace which causes it to bypass the default `skip_blank_lines=True` behavior for `pandas.read_csv`. The issue has been fixed in Augur, but still nice to remove the excess whitespace here to keep things uniform with other pathogen clade TSVs. Note that the trailing whitespace after inherited clade definitions are required.
|
Comparing the outputs for the CI run of this PR to the outputs of the CI run on the main branch from last week. Clade annotations in the final Auspice JSONs match up except for a clade in rsv/b/G. However, it looks like a difference in tree building rather than a difference caused by the clade definitions. Here's a screenshot of the tangletree with the left from this PR and the right from the main branch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Discovered as part of nextstrain/augur#1293 that the clade TSVs for this repo has excess whitespace which causes it to bypass the default
skip_blank_lines=Truebehavior forpandas.read_csv.The issue has been fixed in Augur, but still nice to remove the excess whitespace here to keep things uniform with other pathogen clade TSVs.
Note that the trailing whitespace after inherited clade definitions are required.
Testing