fix: disable non-a-number filtering in clade file parsing #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1293 +/- ##
=======================================
Coverage 69.92% 69.92%
=======================================
Files 67 67
Lines 7161 7162 +1
Branches 1745 1746 +1
=======================================
+ Hits 5007 5008 +1
Misses 1848 1848
Partials 306 306
☔ View full report in Codecov by Sentry. |
victorlin
requested changes
Aug 25, 2023
|
@victorlin do you think this can go in? The empty line handling is still bit wonky. But I think it is better than before... |
Co-authored-by: Richard Neher <richard.neher@unibas.ch>
Co-authored-by: Richard Neher <richard.neher@unibas.ch>
victorlin
force-pushed
the
fix/clades-na
branch
from
085c5ac
to
f5f9590
Compare
|
@rneher I force-pushed a new set of commits to make changes more clear, and added a changelog entry. Will merge after checks pass. |
victorlin
force-pushed
the
fix/clades-na
branch
from
11d414d
to
bf14933
Compare
joverlee521
added a commit
to nextstrain/rsv
that referenced
this pull request
Aug 29, 2023
Discovered as part of nextstrain/augur#1293 that the clade TSVs for this repo has excess whitespace which causes it to bypass the default `skip_blank_lines=True` behavior for `pandas.read_csv`. The issue has been fixed in Augur, but still nice to remove the excess whitespace here to keep things uniform with other pathogen clade TSVs. Note that the trailing whitespace after inherited clade definitions are required.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trival PR to allow gene names 'NA' in clades.tsv
Discussions