Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

critique.py was not working #14

Merged
merged 11 commits into from
Jan 22, 2020
Merged

critique.py was not working #14

merged 11 commits into from
Jan 22, 2020

Conversation

prjemian
Copy link
Contributor

this gets it working again

@prjemian
Copy link
Contributor Author

Make this work with Python3, while we are at it? Why not?

@prjemian
Copy link
Contributor Author

os.path.walk is deprecated, switch to os.walk and refactor

PeterC-DLS
PeterC-DLS reviewed Jan 22, 2020
View reviewed changes
critique.py Outdated Show resolved Hide resolved
PeterC-DLS
PeterC-DLS reviewed Jan 22, 2020
View reviewed changes
critique.py Outdated Show resolved Hide resolved
PeterC-DLS
PeterC-DLS reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes need a tidy up

PeterC-DLS
PeterC-DLS reviewed Jan 22, 2020
View reviewed changes
critique.py Outdated Show resolved Hide resolved
@prjemian
Copy link
Contributor Author

Note that file ./DLS/i16/538039.nxs is reported as HDF5 file but not recognized as NeXus. This is due to the underlying h5py package installed during analysis (version 2.9.0) that does not recognize the utf8 strings in the attributes. Update of h5py to 2.10.0 produces the desired result.

PeterC-DLS
PeterC-DLS approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@prjemian prjemian merged commit c106c85 into master Jan 22, 2020
@prjemian prjemian deleted the 3-critique-data-files branch January 22, 2020 17:55
@prjemian prjemian mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterC-DLS PeterC-DLS PeterC-DLS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prjemian @PeterC-DLS