Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process "trimming" doesnt provide required input for process "qiime_import" #24

Closed
d4straub opened this issue Oct 29, 2018 · 5 comments
Closed

Comments

@d4straub
Copy link
Collaborator

Process "qiime_import" expects as "--input-path $trimmed" a path/to/folder containing all files with trimmed reads. The files with trimmed reads need to follow the naming scheme "*_L001_R{1,2}_001.fastq.gz".

Problems - process "trimming":

  • outputs files with the naming scheme "*_L001_R{1,2}_001.fastq.gz.trimmed" instead of "*_L001_R{1,2}_001.fastq.gz"
  • outputs files are not collected in a folder that is accessible with the process ""qiime_import" parameter "--input-path $trimmed"
  • publishing all trimmed files would create significant data overhead

Problems - process "qiime_import":

  • "--input-path $trimmed" is a channel containing all files from process "trimming" instead of a folder containing all these files
@d4straub d4straub changed the title Process "trimming" doesnt provide output for process "qiime_import" Process "trimming" doesnt provide required input for process "qiime_import" Oct 29, 2018
d4straub added a commit that referenced this issue Oct 30, 2018
@d4straub
Copy link
Collaborator Author

Solved by publishing properly named symlinks for process "qiime_import" by process "trimming"

@apeltzer
Copy link
Member

apeltzer commented Oct 31, 2018

Problem: This can fail if its really using the publishDir directive and we should use dynamic output file names instead. I'll have a look and update this accordingly. Directly using files in paths such as $PWD is not working reliably...

@apeltzer apeltzer reopened this Oct 31, 2018
@d4straub
Copy link
Collaborator Author

d4straub commented Nov 7, 2018

Part of the problem remains after commit 3d96744
Qiime import is now using trimmed.* filenames which leads to sample names with prefix "trimmed.". Therefore the sample names are not matching the ID's in the metadatafile and several processes fail.

@apeltzer
Copy link
Member

apeltzer commented Nov 7, 2018

I guess I'll have to find a way to rename files accordingly to metadata... or stick strictly to using the names of the metadata....

Workaround would also be to create a directory, move the trimmed files there with the same name and use these for the next step.

@apeltzer
Copy link
Member

apeltzer commented Nov 7, 2018

Can confirm this works now :-) Its just not possible to store the same file names in the same work directory, so I create a temporary directory in our work directory for each trimming process in fec5d44 and push the trimmed files (with the same name!) into the next step :-)

@apeltzer apeltzer closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants