Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Input Parameter as Folder #8

Closed
apeltzer opened this issue Sep 26, 2018 · 4 comments
Closed

Read Input Parameter as Folder #8

apeltzer opened this issue Sep 26, 2018 · 4 comments
Assignees
Labels
awaiting review Awaiting a review

Comments

@apeltzer
Copy link
Member

params.reads should only specify the folder, but only files like *_L001_R{1,2}_001.fastq.gz are chosen (QIIME2 PE input requires *_L001_R{1,2}_001.fastq.gz format, so this is required anyway)

@apeltzer apeltzer added the enhancement New feature or request label Sep 26, 2018
@apeltzer apeltzer added this to the V1.1 Olive Steel Panda milestone Sep 26, 2018
@apeltzer apeltzer self-assigned this Sep 28, 2018
@apeltzer apeltzer added awaiting review Awaiting a review and removed enhancement New feature or request labels Nov 12, 2018
@d4straub
Copy link
Collaborator

This doesnt work with 1.0dev. I still need to define --reads "data/*_L001_R{1,2}_001.fastq.gz"
In branch dev I somehow cant find the changes you made in main.nf, but the changes in nextflow.config are present.

@d4straub
Copy link
Collaborator

also, all --singleEnd options would not work at the moment. qiime import is expecting paired end, we would need to implement single end processing in several steps.

@apeltzer
Copy link
Member Author

I created a separate Issue for the second point. For the first, this is specified as folder + pattern and should take this automatically into account. Will have a look later after meeting.

d4straub added a commit that referenced this issue Nov 16, 2018
@d4straub
Copy link
Collaborator

works

ggabernet pushed a commit that referenced this issue Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Awaiting a review
Projects
None yet
Development

No branches or pull requests

2 participants