Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ataqv_mito_reference parameter #294

Merged
merged 3 commits into from
Jun 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Enhancements & fixes

- [[#226](https://github.com/nf-core/atacseq/issues/262)] - Add `ataqv_mito_reference` parameter.
- Optional support of control data analog to nf-core/chipseq.
- Updated pipeline template to [nf-core/tools 2.8](https://github.com/nf-core/tools/releases/tag/2.8)
- Add public_aws_ecr profile for using containers hosted on ECR.
Expand All @@ -15,13 +16,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [[#268](https://github.com/nf-core/atacseq/issues/268)] - Fix error when a bed file is provided using the `--blacklist` option.
- [[#278](https://github.com/nf-core/atacseq/issues/278)] - Make genome fasta file available when `IGV` process is run.
- [[#276](https://github.com/nf-core/atacseq/issues/276)] - Bump version 1.3.1 of ataqv to fix enrichment plots rendering.
- [[#290](https://github.com/nf-core/atacseq/issues/290)] - Fix case-sensitivity issue while sorting bedGraph
- [[#290](https://github.com/nf-core/atacseq/issues/290)] - Fix case-sensitivity issue while sorting bedGraph.

### Parameters

| Old parameter | New parameter |
| ------------- | ---------------- |
| | `--with_control` |
| Old parameter | New parameter |
| ------------- | ------------------------ |
| | `--with_control` |
| | `--ataqv_mito_reference` |

> **NB:** Parameter has been **updated** if both old and new parameter information is present.
> **NB:** Parameter has been **added** if just the new parameter information is present.
Expand Down
1 change: 1 addition & 0 deletions nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ params {
igenomes_base = 's3://ngi-igenomes/igenomes'
igenomes_ignore = false
save_reference = false
ataqv_mito_reference = null

// Options: Trimming
clip_r1 = null
Expand Down
7 changes: 7 additions & 0 deletions nextflow_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,14 @@
"keep_mito": {
"type": "boolean",
"description": "Reads mapping to mitochondrial contig are not filtered from alignments.",
"fa_icon": "fas fa-cart-arrow-down",
"default": false
},
"ataqv_mito_reference": {
"type": "string",
"description": "Sets the value of the ataqv --mitochondrial-reference-name argument",
"help_text": "By default takes the value of the mito_name parameter, if set. However, some plants and algae have chloroplast genomes in addition to a mitochondrial genome and thus mito_name can have values as multiple names that are separated by a | symbol that will break ataqv, in these cases this parameter can be used to overwrite these values.",
"fa_icon": "fas fa-signature"
}
}
},
Expand Down
8 changes: 7 additions & 1 deletion workflows/atacseq.nf
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ for (param in checkPathParamList) { if (param) { file(param, checkIfExists: true
// Check mandatory parameters
if (params.input) { ch_input = file(params.input) } else { exit 1, 'Input samplesheet not specified!' }

// Check ataqv_mito_reference parameter
ataqv_mito_reference = params.ataqv_mito_reference
if (!params.ataqv_mito_reference && params.mito_name) {
ataqv_mito_reference = params.mito_name
}

/*
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CONFIG FILES
Expand Down Expand Up @@ -495,7 +501,7 @@ workflow ATACSEQ {
MERGED_LIBRARY_ATAQV_ATAQV (
ch_bam_peaks,
'NA',
params.mito_name ?: '',
ataqv_mito_reference ?: '',
PREPARE_GENOME.out.tss_bed,
[],
PREPARE_GENOME.out.autosomes
Expand Down