Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge!] Pseudo PR for first release #69

Draft
wants to merge 1,615 commits into
base: first-commit-for-pseudo-pr
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
1615 commits
Select commit Hold shift + click to select a range
43a1c4d
Update nf-core modules
nictru May 30, 2024
b81a30a
Update segemehl unify call
nictru May 30, 2024
0e9cce3
Merge pull request #123 from nf-core/segemehl-update
nictru May 30, 2024
0a98534
Add support for ext.args in ciriquant
nictru May 31, 2024
d5967c5
Merge pull request #124 from nf-core/ciriquant-args
nictru May 31, 2024
0cc85b0
Add strandedness to samplesheet
nictru May 31, 2024
30af702
Add support for strandedness in ciriquant
nictru May 31, 2024
9c58899
Revise DCC parameters
nictru May 31, 2024
f38c58c
Implement ext.args interface for find_circ
nictru May 31, 2024
ca15b3a
Fix trimming indentation in modules.config
nictru May 31, 2024
2b54d43
Move segemehl index location in modules.config
nictru May 31, 2024
022d66e
Add strandedness to bowtie2 calls
nictru May 31, 2024
a41eab1
Add strandedness to find_circ
nictru May 31, 2024
8957a7e
Add strandedness documentation
nictru Jun 9, 2024
c65e604
Add samplesheet validation for strandedness of runs of the same sample
nictru Jun 9, 2024
0ea2e75
Update modules
nictru Jun 9, 2024
98c1070
Merge pull request #132 from nf-core/module-updates_24-06
nictru Jun 9, 2024
e17b3ac
Merge pull request #131 from nf-core/strandedness
nictru Jun 10, 2024
8150c43
Add new STATISTICAL_TESTS subworkflow
nictru Jun 10, 2024
7ef6b03
Implement CIRCTEST_PREPARE
nictru Jun 10, 2024
5893d6d
Implement circTest
nictru Jun 11, 2024
9c5906d
Fix circtest problems
nictru Jun 11, 2024
21236c8
Re-enable circtest plots
nictru Jun 11, 2024
69f82c0
Fix circtest plot problem
nictru Jun 11, 2024
d2839a3
Remove artifacts of old differential expression analysis
nictru Jun 11, 2024
b67e980
Simplify annotation module
nictru Jun 11, 2024
6fdc23d
Switch annotation to template syntax
nictru Jun 11, 2024
a87569b
Remove unused combine_quantification script
nictru Jun 11, 2024
fa7cc09
Switch merge_samples to template syntax
nictru Jun 11, 2024
f3e63fd
Switch to template syntax in merge_tools
nictru Jun 11, 2024
4a49a48
Remove custom DESeq2 module
nictru Jun 11, 2024
ec9198b
Remove DIFFERENTIAL_EXPRESSION traces
nictru Jun 11, 2024
3441048
Remove unwanted biotypes
nictru Jun 11, 2024
abd9dcd
Fix linting problems
nictru Jun 11, 2024
ffbada6
Prettier
nictru Jun 11, 2024
2d259c3
Remove traces of differential_expression in docs
nictru Jun 12, 2024
00d5f0a
Update modules/local/circtest/circtest/main.nf
nictru Jun 14, 2024
4f37a03
Clarify docs
nictru Jun 14, 2024
4974eaf
Update gnu/sort
nictru Jun 14, 2024
ad02b05
Merge pull request #147 from nf-core/144-differential-expression
nictru Jun 14, 2024
aac8f81
Change conditions for downstream tasks
May 29, 2024
d24d1ba
Changed documentation 'phenotype' and 'mature'
Jun 2, 2024
c046322
Remove module traces of module parameter
nictru Jun 14, 2024
d7b6258
Fix nextflow_schema.json
nictru Jun 14, 2024
d73a8c2
Make phenotype optional for quantification
nictru Jun 14, 2024
fdc9667
Improve documentation of the phenotype parameter
nictru Jun 14, 2024
9f9e967
Update documentation for enabling miRNA prediction
nictru Jun 14, 2024
a0fb084
Update README
nictru Jun 14, 2024
7fb28ad
Update usage documentation to follow rnaseq example
nictru Jun 14, 2024
1d66688
Update nextflow schema order
nictru Jun 14, 2024
ee159a2
Update ouput docs
nictru Jun 14, 2024
ab74eb5
Prettier
nictru Jun 14, 2024
c7077d9
Merge pull request #148 from nf-core/deprecate_module
nictru Jun 15, 2024
b8474a0
Add annotations parameter and pass it to the according position
nictru Jun 17, 2024
30e28dd
Make annotations parameter optional
nictru Jun 17, 2024
a3f165c
Unify annotation naming
nictru Jun 17, 2024
706e797
First database annotation implementation
nictru Jun 18, 2024
8ecd3cd
Fix per-sample DB annotation
nictru Jun 18, 2024
6a97b0c
Change database intersection strategy
nictru Jun 18, 2024
b511c0c
Make sure databases are optional
nictru Jun 18, 2024
b4c2f49
Add db annotation to annotation python script
nictru Jun 18, 2024
cbaf4fd
Fix first row length bug
nictru Jun 18, 2024
8999212
Make sure annotation input is optional
nictru Jun 18, 2024
995775b
Merge pull request #149 from nf-core/138-implement-circrna-database-a…
nictru Jun 18, 2024
fab59a3
Use psirc bioconda package
nictru Jun 19, 2024
8311bab
Escape problematic $
nictru Jun 19, 2024
9b57e7f
Fix problematic $ also in psirc index
nictru Jun 19, 2024
98923dd
Merge pull request #152 from nf-core/115-add-bioconda-recipe-for-psirc
nictru Jun 19, 2024
fbabe35
Implement GTF filtering
nictru Jun 23, 2024
15ffbb0
Escape backslashes
nictru Jun 23, 2024
50226e8
Fix pandas references
nictru Jun 24, 2024
81adab0
Remove problematic r-base singularity image
nictru Jun 24, 2024
bed731c
Add missing environment yml files
nictru Jun 24, 2024
bc8acdf
Add another missing environment yml
nictru Jun 24, 2024
900e1fc
Add tximeta environment.yml
nictru Jun 25, 2024
c3783b9
Fix GTF sorting
nictru Jun 25, 2024
cb72c91
Fix typo on merge_experiments conda environment
nictru Jun 25, 2024
6c73c83
Fix merge_experiments environment definition
nictru Jun 25, 2024
aaebb74
Fix typo
nictru Jun 25, 2024
8fce8c2
Merge pull request #153 from nf-core/conda-envs
nictru Jun 25, 2024
34a3a80
Fix circexplorer2 count location
nictru Jun 27, 2024
4a2d30f
Merge pull request #154 from nf-core/circexplorer2-counts
nictru Jun 27, 2024
5b25150
Use nf core module for gtffilter functionality
nictru Jul 15, 2024
853e9da
Rename GTFFILTER module accession
nictru Jul 15, 2024
73bf5e4
Update GTFFILTER module
nictru Jul 15, 2024
009e891
Merge pull request #157 from nf-core/151-error-no-genomic-sequence-av…
nictru Jul 15, 2024
342964d
Add filter for circular RNAs to find_circ
nictru Aug 1, 2024
3be2733
Update comment
nictru Aug 1, 2024
eb025f6
Merge pull request #165 from nf-core/find_circ_bug
nictru Aug 1, 2024
a66fcd3
Add error message for empty intersections
nictru Jul 12, 2024
02a19f2
Add docs for GTF required attributes
nictru Jul 12, 2024
2e3d667
Add check for presence of attributes in annotation intersection
nictru Jul 12, 2024
3a8e88c
Fix bug in missing attribute check
nictru Jul 12, 2024
b008653
Implement Segemehl grouping
nictru Aug 1, 2024
9d79972
Add bedtools groupby
nictru Aug 1, 2024
50a1817
Fix segemehl grouping
nictru Aug 1, 2024
9fc67a1
Implement ordering of segemehl results
nictru Aug 1, 2024
08d56cc
Implement check for duplicates in tool results
nictru Aug 1, 2024
7d470e6
Implement custom BSJome generation
nictru Aug 2, 2024
8719a3f
Extract annotation from discovery
nictru Aug 2, 2024
8509cb0
Fix bug in tool filtering
nictru Aug 2, 2024
d26712e
Fix saveAs conditions
nictru Aug 2, 2024
b45cea8
Fix some output definitions
nictru Aug 2, 2024
11892e2
Add per-sample and combined output directories for discovery
nictru Aug 2, 2024
a0f3e73
Add tools subdirectory to discovery outdir
nictru Aug 2, 2024
ea4ef34
Implement separate processes for FASTA extraction
nictru Aug 2, 2024
8e7e441
Add fastas to discovery output
nictru Aug 2, 2024
4e9f4ab
Add output directory for statistical tests
nictru Aug 2, 2024
4e2ce6c
Handle output of circtest_prepare
nictru Aug 2, 2024
ca5e4b6
Improve QC output directory structure
nictru Aug 2, 2024
f78404e
Unify discovery tool output directories
nictru Aug 2, 2024
654caa5
Improve quantification outdir structure
nictru Aug 2, 2024
395febd
Improve quantification outdir structure
nictru Aug 2, 2024
45cfd02
Make some more outdir optimizations
nictru Aug 2, 2024
dd682fb
Remove tool reference in mirna outdir
nictru Aug 2, 2024
baf6d37
Add annotation back to discovery
nictru Aug 2, 2024
2ff430e
Improve annotation output formatting
nictru Aug 2, 2024
c8fc5c3
Remove unnecessary outputs from circrna_discovery
nictru Aug 2, 2024
b19813a
Fix bug in tool filtering
nictru Aug 2, 2024
1f00d9f
Prevent pipeline from failing if no circRNAs are found
nictru Aug 2, 2024
35ef315
Improve annotation output format
nictru Aug 3, 2024
d153402
Remove traces of old merging functionality
nictru Aug 3, 2024
eeb1895
Make sure pipeline fails in an ordered way if no circRNAs are found
nictru Aug 3, 2024
9bf0609
Improve error message for no circRNAs found
nictru Aug 3, 2024
ccd0bda
Linting
nictru Aug 3, 2024
ddbd2f5
Update first section of introduction
nictru Aug 3, 2024
f8ce1a6
Update credits
nictru Aug 3, 2024
17c692d
Restructure usage docs
nictru Aug 3, 2024
1982098
Add plans for future implementations to README
nictru Aug 3, 2024
9e9fdd9
Rename CIRCRNA_DISCOVERY to BSJ_DETECTION
nictru Aug 3, 2024
532c956
Rename params.tool to params.tools
nictru Aug 3, 2024
ac23046
Remove unused species_id parameter
nictru Aug 3, 2024
fde46d0
Apply parameter changes to test configs
nictru Aug 3, 2024
a808527
Change some default values
nictru Aug 3, 2024
9f6a709
Finish updating usage docs
nictru Aug 3, 2024
b0f797b
Add output directory structure documentation
nictru Aug 3, 2024
5bdd08b
Add documentation for references output
nictru Aug 3, 2024
bd08029
Improve STAR output documentation
nictru Aug 3, 2024
a311c4a
Improve output docs for various detection tools
nictru Aug 3, 2024
7314a42
Finalize BSJ detection output docs
nictru Aug 3, 2024
c38f066
Update output docs for mirna prediction and quantification
nictru Aug 3, 2024
cd5c1d4
Prettier
nictru Aug 3, 2024
3d25e2d
Update README.md
nictru Aug 6, 2024
ffd92e3
Update README.md
nictru Aug 6, 2024
fd16ccc
Update docs/output.md
nictru Aug 6, 2024
7535170
Update docs/output.md
nictru Aug 6, 2024
0ffaf30
Update nextflow_schema.json
nictru Aug 6, 2024
6549757
Update nextflow_schema.json
nictru Aug 6, 2024
636330d
Update docs/output.md
nictru Aug 6, 2024
f3b9880
Update docs/output.md
nictru Aug 6, 2024
96a20d5
Update docs/usage.md
nictru Aug 6, 2024
6c45fa8
Update docs/usage.md
nictru Aug 6, 2024
2209284
Update docs/output.md
nictru Aug 6, 2024
ff1d11a
Update docs/output.md
nictru Aug 6, 2024
e3844bb
Update docs/output.md
nictru Aug 6, 2024
cce50cb
Update docs/output.md
nictru Aug 6, 2024
af15e96
Fix syntax error in nextflow_schema.json
nictru Aug 6, 2024
237bf49
Write pipeline name in standard formatting in output docs
nictru Aug 6, 2024
90172a0
Update bsj_reads help text
nictru Aug 6, 2024
4062690
Merge pull request #159 from nf-core/150-problems-with-empty-annotati…
nictru Aug 6, 2024
9a4ece6
Adding mirna_expression param to subworkflow mirna_prediction
mweyrich28 Apr 26, 2024
ea567a3
Adding mirna_expression param to config
mweyrich28 Apr 26, 2024
b800bdb
Adding mirna_expression param to nextflow_schema.json
mweyrich28 Apr 26, 2024
0aa5c0f
adding process DESEQ2_NORMALIZATION
Apr 29, 2024
4a90115
Adding deseq2 module and mirna normalization module (including params)
May 10, 2024
3617290
Adding formatting of mirna prediction output
May 10, 2024
e7a8f73
embedding mirna filtering and output formatting in mirna_prediction s…
May 10, 2024
3596c5f
extending miranda output formatting to ignore unwanted prefix
May 11, 2024
2715dfa
implementing concatenation of mirna predictions, work in progress
May 15, 2024
60fe2a8
preparing majority vote
May 17, 2024
8a7772d
fixing channel structure of predictions for cat cat
May 17, 2024
c7a82da
Embedding majority vote for mirna predictions
mweyrich28 May 18, 2024
bb5d520
updating miranda to majority gawk
mweyrich28 Jun 1, 2024
d9dea25
adding compute correlations module
mweyrich28 Jun 1, 2024
f51de26
todos
mweyrich28 Jun 1, 2024
c31d3d9
Replace tabs with spaces
nictru Jun 1, 2024
eb03b02
Implement MIRNA_BINDINGSITES subworkflow
nictru Jun 1, 2024
a812857
Add versions capture for MIRNA_BINDINGSITES
nictru Jun 1, 2024
d0360e2
Use full transcriptome in miRNA binding site detection
nictru Jun 1, 2024
282ddc6
Use BIOAWK for ADD_BACKSPLICE
nictru Jun 1, 2024
91436e3
Pass correct count info to mirna_prediction
nictru Jun 1, 2024
05f588f
Implement transcriptome batch splitting in MIRNA_BINDINGSITES
nictru Jun 1, 2024
7a097fe
Improve targetscan input preparation
nictru Jun 1, 2024
4683f79
Improve majority vote script
nictru Jun 1, 2024
5852fe9
Improve styling
nictru Jun 1, 2024
8d2c151
Add majority targets output
nictru Jun 1, 2024
56007a7
Transpose binding site output
nictru Jun 1, 2024
825f0d1
Start refactoring correlation
nictru Jun 1, 2024
4317c98
Implement first draft of correlation analysis
nictru Jun 1, 2024
2bdabcc
Save correlation results
nictru Jun 1, 2024
bb0a858
Switch correlation output to TSV
nictru Jun 1, 2024
8c2ae55
Handle correlation output channels
nictru Jun 1, 2024
9e97abb
fixing MIRNA_TARGETS
mweyrich28 Jun 7, 2024
2be8d5e
Filtering mature based on filtered mirnas
mweyrich28 Jun 17, 2024
0f6313d
Adding missing .collect() to MIRANDA process
mweyrich28 Jun 21, 2024
3d8b9ef
fixing filtering of mature
mweyrich28 Jun 22, 2024
d9619dc
Cleaning up
mweyrich28 Jun 22, 2024
d87def8
Adding param to switch between spearman and pearson correlation
mweyrich28 Jun 22, 2024
bd5345e
More resources for MAJORITY_VOTE
mweyrich28 Jun 23, 2024
fbc094a
removing todo comment
mweyrich28 Jun 23, 2024
b5adea2
removing TODO comment
mweyrich28 Jun 25, 2024
ff1edcf
correlations output set to optional
mweyrich28 Jun 25, 2024
1e8b04f
Fix major rebase problems
nictru Aug 4, 2024
cdb265e
Fix small bug with backsplice junction adding
nictru Aug 4, 2024
abac8e2
Improve mirna prediction formatting
nictru Aug 4, 2024
f3a6233
Improve output structure for mirna prediction
nictru Aug 4, 2024
2b28c80
fixing formatting in modules
mweyrich28 Aug 6, 2024
86c7958
adjusting mirna_min_reads to match nextflow_schema
mweyrich28 Aug 6, 2024
3ddfe3e
fixing formatting and adding missing allOf field for mirna_processing…
mweyrich28 Aug 6, 2024
45dd407
removing non used configs in modules.config
mweyrich28 Aug 6, 2024
4cbb345
updating nf-core modules
mweyrich28 Aug 6, 2024
8027686
Revert "updating nf-core modules"
mweyrich28 Aug 6, 2024
b3c1ffd
only updating necessary modules
mweyrich28 Aug 6, 2024
35ebe75
fixing pattern for input file of mirna_expression
mweyrich28 Aug 6, 2024
399a16d
Adding missing html tag in output.md
mweyrich28 Aug 7, 2024
e550ec2
updating output.md in docs
mweyrich28 Aug 7, 2024
8fef0f7
capitalizing 'tsv' to TSV
mweyrich28 Aug 7, 2024
740cc43
updating usage.md
mweyrich28 Aug 7, 2024
5f9a7f9
updating README.md
mweyrich28 Aug 7, 2024
596df45
making mirna_expression parameter optional
mweyrich28 Aug 7, 2024
6479a53
Apply suggestions from code review
mweyrich28 Aug 7, 2024
e52e401
renaming mirna_vote to mirna_tool_filter
mweyrich28 Aug 7, 2024
e49b947
applying prettier
mweyrich28 Aug 8, 2024
edafce4
renaming mirna_tools in nextflow.config
mweyrich28 Aug 8, 2024
4d514b4
fixing indent
mweyrich28 Aug 8, 2024
737da80
deleting redundant file
mweyrich28 Aug 8, 2024
b112f0c
rewording usage
mweyrich28 Aug 8, 2024
bd7cd36
rewording usage
mweyrich28 Aug 8, 2024
7f165ba
reformatting compute correlations
mweyrich28 Aug 8, 2024
5708f75
reformatting normalization
mweyrich28 Aug 8, 2024
3b7074d
reformatting majority vote
mweyrich28 Aug 8, 2024
6ac49fd
reformatting majority vote py
mweyrich28 Aug 8, 2024
26e7599
reformatting mirna filtering R
mweyrich28 Aug 8, 2024
050bb4d
reformatting mirna bindingsites
mweyrich28 Aug 8, 2024
1cd2841
reformatting mirna prediction
mweyrich28 Aug 8, 2024
80edcc5
fixing param mirna_tool_filter
mweyrich28 Aug 8, 2024
0106c3a
checking if mirna_expression is null before passing it to file()
mweyrich28 Aug 8, 2024
2be53ee
Apply suggestions from code review
mweyrich28 Aug 8, 2024
e0afb0a
applying correct format to mirna_tools
mweyrich28 Aug 8, 2024
5082d4f
updating default format of mirna_tools
mweyrich28 Aug 8, 2024
b233bb8
Merge pull request #166 from nf-core/sponging
mweyrich28 Aug 8, 2024
6f69c93
Add credits for mweyrich
nictru Aug 8, 2024
3e1ce6f
Merge pull request #167 from nf-core/credits-mweyrich
nictru Aug 8, 2024
2977ef0
Implement count extraction
nictru Aug 8, 2024
16695da
Implement per-tool count combination across samples
nictru Aug 8, 2024
38c2e49
Restructure BSJ detection workflow
nictru Aug 8, 2024
a1acac7
Update docs
nictru Aug 8, 2024
d0f7cfe
Perform outer join on counts
nictru Aug 8, 2024
7ac747e
Imporve BSJ_DETECTION order
nictru Aug 8, 2024
c9a5eb7
Merge pull request #168 from nf-core/per-tool-quantification
nictru Aug 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"name": "nfcore",
"image": "nfcore/gitpod:latest",
"remoteUser": "gitpod",
"runArgs": ["--privileged"],

// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
// Set *default* container specific settings.json values on container create.
"settings": {
"python.defaultInterpreterPath": "/opt/conda/bin/python",
"python.linting.enabled": true,
"python.linting.pylintEnabled": true,
"python.formatting.autopep8Path": "/opt/conda/bin/autopep8",
"python.formatting.yapfPath": "/opt/conda/bin/yapf",
"python.linting.flake8Path": "/opt/conda/bin/flake8",
"python.linting.pycodestylePath": "/opt/conda/bin/pycodestyle",
"python.linting.pydocstylePath": "/opt/conda/bin/pydocstyle",
"python.linting.pylintPath": "/opt/conda/bin/pylint"
},

// Add the IDs of extensions you want installed when the container is created.
"extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"]
}
}
}
24 changes: 24 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
root = true

[*]
charset = utf-8
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
indent_size = 4
indent_style = space

[*.{md,yml,yaml,html,css,scss,js}]
indent_size = 2

# These files are edited and tested upstream in nf-core/modules
[/modules/nf-core/**]
charset = unset
end_of_line = unset
insert_final_newline = unset
trim_trailing_whitespace = unset
indent_style = unset
indent_size = unset

[/assets/email*]
indent_size = unset
3 changes: 3 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
*.config linguist-language=nextflow
*.nf.test linguist-language=nextflow
modules/nf-core/** linguist-generated
subworkflows/nf-core/** linguist-generated
1 change: 1 addition & 0 deletions .github/.dockstore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ version: 1.2
workflows:
- subclass: nfl
primaryDescriptorPath: /nextflow.config
publish: True
83 changes: 73 additions & 10 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,19 @@ Please use the pre-filled template to save time.
However, don't be put off by this template - other more general issues and suggestions are welcome!
Contributions to the code are even more welcome ;)

> If you need help using or modifying nf-core/circrna then the best place to ask is on the nf-core Slack [#circrna](https://nfcore.slack.com/channels/circrna) channel ([join our Slack here](https://nf-co.re/join/slack)).
:::info
If you need help using or modifying nf-core/circrna then the best place to ask is on the nf-core Slack [#circrna](https://nfcore.slack.com/channels/circrna) channel ([join our Slack here](https://nf-co.re/join/slack)).
:::

## Contribution workflow

If you'd like to write some code for nf-core/circrna, the standard workflow is as follows:

1. Check that there isn't already an issue about your idea in the [nf-core/circrna issues](https://github.com/nf-core/circrna/issues) to avoid duplicating work
* If there isn't one already, please create one so that others know you're working on this
1. Check that there isn't already an issue about your idea in the [nf-core/circrna issues](https://github.com/nf-core/circrna/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
2. [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [nf-core/circrna repository](https://github.com/nf-core/circrna) to your GitHub account
3. Make the necessary changes / additions within your forked repository
4. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged
3. Make the necessary changes / additions within your forked repository following [Pipeline conventions](#pipeline-contribution-conventions)
4. Use `nf-core schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
5. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged

If you're not used to this workflow with git, you can start with some [docs from GitHub](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests) or even their [excellent `git` resources](https://try.github.io/).

Expand All @@ -30,14 +32,14 @@ Typically, pull-requests are only fully reviewed when these tests are passing, t

There are typically two types of tests that run:

### Lint Tests
### Lint tests

`nf-core` has a [set of guidelines](https://nf-co.re/developers/guidelines) which all pipelines must adhere to.
To enforce these and ensure that all pipelines stay in sync, we have developed a helper tool which runs checks on the pipeline code. This is in the [nf-core/tools repository](https://github.com/nf-core/tools) and once installed can be run locally with the `nf-core lint <pipeline-directory>` command.

If any failures or warnings are encountered, please follow the listed URL for more documentation.

### Pipeline Tests
### Pipeline tests

Each `nf-core` pipeline should be set up with a minimal set of test-data.
`GitHub Actions` then runs the pipeline on this data to ensure that it exits successfully.
Expand All @@ -48,10 +50,71 @@ These tests are run both with the latest available version of `Nextflow` and als

:warning: Only in the unlikely and regretful event of a release happening with a bug.

* On your own fork, make a new branch `patch` based on `upstream/master`.
* Fix the bug, and bump version (X.Y.Z+1).
* A PR should be made on `master` from patch to directly this particular bug.
- On your own fork, make a new branch `patch` based on `upstream/master`.
- Fix the bug, and bump version (X.Y.Z+1).
- A PR should be made on `master` from patch to directly this particular bug.

## Getting help

For further information/help, please consult the [nf-core/circrna documentation](https://nf-co.re/circrna/usage) and don't hesitate to get in touch on the nf-core Slack [#circrna](https://nfcore.slack.com/channels/circrna) channel ([join our Slack here](https://nf-co.re/join/slack)).

## Pipeline contribution conventions

To make the nf-core/circrna code and processing logic more understandable for new contributors and to ensure quality, we semi-standardise the way the code and other contributions are written.

### Adding a new step

If you wish to contribute a new step, please use the following coding standards:

1. Define the corresponding input channel into your new process from the expected previous process channel
2. Write the process block (see below).
3. Define the output channel if needed (see below).
4. Add any new parameters to `nextflow.config` with a default (see below).
5. Add any new parameters to `nextflow_schema.json` with help text (via the `nf-core schema build` tool).
6. Add sanity checks and validation for all relevant parameters.
7. Perform local tests to validate that the new code works as expected.
8. If applicable, add a new test command in `.github/workflow/ci.yml`.
9. Update MultiQC config `assets/multiqc_config.yml` so relevant suffixes, file name clean up and module plots are in the appropriate order. If applicable, add a [MultiQC](https://https://multiqc.info/) module.
10. Add a description of the output files and if relevant any appropriate images from the MultiQC report to `docs/output.md`.

### Default values

Parameters should be initialised / defined with default values in `nextflow.config` under the `params` scope.

Once there, use `nf-core schema build` to add to `nextflow_schema.json`.

### Default processes resource requirements

Sensible defaults for process resource requirements (CPUs / memory / time) for a process should be defined in `conf/base.config`. These should generally be specified generic with `withLabel:` selectors so they can be shared across multiple processes/steps of the pipeline. A nf-core standard set of labels that should be followed where possible can be seen in the [nf-core pipeline template](https://github.com/nf-core/tools/blob/master/nf_core/pipeline-template/conf/base.config), which has the default process as a single core-process, and then different levels of multi-core configurations for increasingly large memory requirements defined with standardised labels.

The process resources can be passed on to the tool dynamically within the process with the `${task.cpu}` and `${task.memory}` variables in the `script:` block.

### Naming schemes

Please use the following naming schemes, to make it easy to understand what is going where.

- initial process channel: `ch_output_from_<process>`
- intermediate and terminal channels: `ch_<previousprocess>_for_<nextprocess>`

### Nextflow version bumping

If you are using a new feature from core Nextflow, you may bump the minimum required version of nextflow in the pipeline with: `nf-core bump-version --nextflow . [min-nf-version]`

### Images and figures

For overview images and other documents we follow the nf-core [style guidelines and examples](https://nf-co.re/developers/design_guidelines).

## GitHub Codespaces

This repo includes a devcontainer configuration which will create a GitHub Codespaces for Nextflow development! This is an online developer environment that runs in your browser, complete with VSCode and a terminal.

To get started:

- Open the repo in [Codespaces](https://github.com/nf-core/circrna/codespaces)
- Tools installed
- nf-core
- Nextflow

Devcontainer specs:

- [DevContainer config](.devcontainer/devcontainer.json)
50 changes: 0 additions & 50 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

50 changes: 50 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: Bug report
description: Report something that is broken or incorrect
labels: bug
body:
- type: markdown
attributes:
value: |
Before you post this issue, please check the documentation:

- [nf-core website: troubleshooting](https://nf-co.re/usage/troubleshooting)
- [nf-core/circrna pipeline documentation](https://nf-co.re/circrna/usage)

- type: textarea
id: description
attributes:
label: Description of the bug
description: A clear and concise description of what the bug is.
validations:
required: true

- type: textarea
id: command_used
attributes:
label: Command used and terminal output
description: Steps to reproduce the behaviour. Please paste the command you used to launch the pipeline and the output from your terminal.
render: console
placeholder: |
$ nextflow run ...

Some output where something broke

- type: textarea
id: files
attributes:
label: Relevant files
description: |
Please drag and drop the relevant files here. Create a `.zip` archive if the extension is not allowed.
Your verbose log file `.nextflow.log` is often useful _(this is a hidden file in the directory where you launched the pipeline)_ as well as custom Nextflow configuration files.

- type: textarea
id: system
attributes:
label: System information
description: |
* Nextflow version _(eg. 23.04.0)_
* Hardware _(eg. HPC, Desktop, Cloud)_
* Executor _(eg. slurm, local, awsbatch)_
* Container engine: _(e.g. Docker, Singularity, Conda, Podman, Shifter, Charliecloud, or Apptainer)_
* OS _(eg. CentOS Linux, macOS, Linux Mint)_
* Version of nf-core/circrna _(eg. 1.1, 1.5, 1.8.2)_
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
blank_issues_enabled: false
contact_links:
- name: Join nf-core
url: https://nf-co.re/join
Expand Down
32 changes: 0 additions & 32 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: Feature request
description: Suggest an idea for the nf-core/circrna pipeline
labels: enhancement
body:
- type: textarea
id: description
attributes:
label: Description of feature
description: Please describe your suggestion for a new feature. It might help to describe a problem or use case, plus any alternatives that you have considered.
validations:
required: true
13 changes: 9 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,13 @@ Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/circ

## PR checklist

- [ ] This comment contains a description of changes (with reason)
- [ ] `CHANGELOG.md` is updated
- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] Documentation in `docs` is updated
- [ ] If necessary, also make a PR on the [nf-core/circrna branch on the nf-core/test-datasets repo](https://github.com/nf-core/test-datasets/pull/new/nf-core/circrna)
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/circrna/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/circrna _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
- [ ] Make sure your code lints (`nf-core lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
- [ ] Usage Documentation in `docs/usage.md` is updated.
- [ ] Output Documentation in `docs/output.md` is updated.
- [ ] `CHANGELOG.md` is updated.
- [ ] `README.md` is updated (including new tool citations and authors/contributors).
5 changes: 0 additions & 5 deletions .github/markdownlint.yml

This file was deleted.

Loading